Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issue 10557002: MIPS: Share optimized code for closures. (Closed)

Created:
8 years, 6 months ago by palfia
Modified:
8 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Share optimized code for closures. Port r11817 (616dfcf0) Original commit message: Each SharedFunctionInfo gets an optimized code map to store one optimized code object per context. When allocating a new closure we consult this map and check if there is optimized code that can be shared. BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=11848

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -16 lines) Patch
M src/mips/code-stubs-mips.cc View 5 chunks +89 lines, -6 lines 1 comment Download
M src/mips/deoptimizer-mips.cc View 5 chunks +31 lines, -8 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
palfia
8 years, 6 months ago (2012-06-15 10:43:00 UTC) #1
Michael Starzinger
8 years, 6 months ago (2012-06-18 12:41:38 UTC) #2
LGTM (with one comment). But still landing and addressing comment in a separate
CL.

https://chromiumcodereview.appspot.com/10557002/diff/1/src/mips/code-stubs-mi...
File src/mips/code-stubs-mips.cc (right):

https://chromiumcodereview.appspot.com/10557002/diff/1/src/mips/code-stubs-mi...
src/mips/code-stubs-mips.cc:162: __ Branch(&install_unoptimized);
It seems that this branch unconditionally installs the unoptimized code if the
first entry in the table doesn't match. This bug is also present on ARM and
seemed to have slipped my review of the original CL. I'll fix that in a separate
CL for both architectures after landing this.

Powered by Google App Engine
This is Rietveld 408576698