Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Side by Side Diff: tests/html/indexeddb_2_test.dart

Issue 10556049: Address Stephen's comments. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « tests/html/indexeddb_1_test.dart ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #library('IndexedDB1Test'); 1 #library('IndexedDB1Test');
2 #import('../../lib/unittest/unittest.dart'); 2 #import('../../lib/unittest/unittest.dart');
3 #import('../../lib/unittest/html_config.dart'); 3 #import('../../lib/unittest/html_config.dart');
4 #import('dart:html'); 4 #import('dart:html');
5 #import('dart:coreimpl'); 5 #import('dart:coreimpl');
6 #import('utils.dart'); 6 #import('utils.dart');
7 7
8 // Write and re-read Maps: simple Maps; Maps with DAGs; Maps with cycles. 8 // Write and re-read Maps: simple Maps; Maps with DAGs; Maps with cycles.
9 9
10 final String DB_NAME = 'Test'; 10 final String DB_NAME = 'Test';
(...skipping 21 matching lines...) Expand all
32 var transaction = db.transaction(storeName, 'readonly'); 32 var transaction = db.transaction(storeName, 'readonly');
33 var request = transaction.objectStore(storeName).getObject(key); 33 var request = transaction.objectStore(storeName).getObject(key);
34 request.on.success.add(expectAsync1((e) { 34 request.on.success.add(expectAsync1((e) {
35 var object = e.target.result; 35 var object = e.target.result;
36 check(value, object); 36 check(value, object);
37 }) 37 })
38 ); 38 );
39 request.on.error.add(fail); 39 request.on.error.add(fail);
40 } 40 }
41 41
42 step1([e]) { 42 step1() {
43 var transaction = db.transaction([storeName], 'readwrite'); 43 var transaction = db.transaction([storeName], 'readwrite');
44 var request = transaction.objectStore(storeName).put(value, key); 44 var request = transaction.objectStore(storeName).put(value, key);
45 request.on.success.add(expectAsync1(step2)); 45 request.on.success.add(expectAsync1(step2));
46 request.on.error.add(fail); 46 request.on.error.add(fail);
47 } 47 }
48 48
49 initDb(e) { 49 initDb(e) {
50 db = e.target.result; 50 db = e.target.result;
51 if (version != db.version) { 51 if (version != db.version) {
52 // TODO. Some browsers do this the w3 way - passing the version to the 52 // TODO. Some browsers do this the w3 way - passing the version to the
53 // open call and listening to onversionchange. Can we feature-detect the 53 // open call and listening to onversionchange. Can we feature-detect the
54 // difference and make it work? 54 // difference and make it work?
55 var request = db.setVersion(version); 55 var request = db.setVersion(version);
56 request.on.success.add( 56 request.on.success.add(
57 expectAsync1((e) { 57 expectAsync1((e) {
58 createObjectStore(); 58 createObjectStore();
59 59
60 var transaction = e.target.result; 60 var transaction = e.target.result;
61 transaction.on.complete.add(expectAsync1(step1)); 61 transaction.on.complete.add(expectAsync1((e) => step1()));
62 transaction.on.error.add(fail); 62 transaction.on.error.add(fail);
63 }) 63 })
64 ); 64 );
65 request.on.error.add(fail); 65 request.on.error.add(fail);
66 } else { 66 } else {
67 step1(); 67 step1();
68 } 68 }
69 } 69 }
70 70
71 var request = window.indexedDB.open(dbName); 71 var request = window.indexedDB.open(dbName);
(...skipping 19 matching lines...) Expand all
91 test('test_DAG', testReadWrite(123, obj2, verifyGraph)); 91 test('test_DAG', testReadWrite(123, obj2, verifyGraph));
92 test('test_cycle', testReadWrite(123, obj3, verifyGraph)); 92 test('test_cycle', testReadWrite(123, obj3, verifyGraph));
93 test('test_simple_splay', testReadWrite(123, obj4, verifyGraph)); 93 test('test_simple_splay', testReadWrite(123, obj4, verifyGraph));
94 } 94 }
95 95
96 main() { 96 main() {
97 useHtmlConfiguration(); 97 useHtmlConfiguration();
98 98
99 tests_dynamic(); 99 tests_dynamic();
100 } 100 }
OLDNEW
« no previous file with comments | « tests/html/indexeddb_1_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698