[File Manager] Avoiding confusion between "Watch" and "Open" actions for video files

[File Manager] Avoiding confusion between "Watch" and "Open" actions for video files


BUG=
TEST=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=142938

[Vladislav Kaznacheev, 2012-06-18 14:38:03]

Please review

[dgozman, 2012-06-18 15:21:14]

https://chromiumcodereview.appspot.com/10556041/diff/1/chrome/browser/chromeo...
File chrome/browser/chromeos/extensions/file_handler_util.cc (right):

https://chromiumcodereview.appspot.com/10556041/diff/1/chrome/browser/chromeo...
chrome/browser/chromeos/extensions/file_handler_util.cc:236: const std::string &
extension_id,
no space before &

https://chromiumcodereview.appspot.com/10556041/diff/1/chrome/browser/chromeo...
chrome/browser/chromeos/extensions/file_handler_util.cc:240:
!(iter->handler->extension_id() == extension_id &&
I'd indent this with 3 more spaces.

https://chromiumcodereview.appspot.com/10556041/diff/1/chrome/browser/chromeo...
chrome/browser/chromeos/extensions/file_handler_util.cc:242: iter++;
AFAIK, while body must be a block.

https://chromiumcodereview.appspot.com/10556041/diff/1/chrome/browser/chromeo...
File chrome/browser/chromeos/extensions/file_manager_util.h (right):

https://chromiumcodereview.appspot.com/10556041/diff/1/chrome/browser/chromeo...
chrome/browser/chromeos/extensions/file_manager_util.h:25: extern const char
kFileBrowserGalleryTaskId[];
Where are the definitions of these constants?

[Vladislav Kaznacheev, 2012-06-18 17:05:54]

https://chromiumcodereview.appspot.com/10556041/diff/1/chrome/browser/chromeo...
File chrome/browser/chromeos/extensions/file_handler_util.cc (right):

https://chromiumcodereview.appspot.com/10556041/diff/1/chrome/browser/chromeo...
chrome/browser/chromeos/extensions/file_handler_util.cc:236: const std::string &
extension_id,
On 2012/06/18 15:21:14, dgozman wrote:
> no space before &

Done.

https://chromiumcodereview.appspot.com/10556041/diff/1/chrome/browser/chromeo...
chrome/browser/chromeos/extensions/file_handler_util.cc:240:
!(iter->handler->extension_id() == extension_id &&
On 2012/06/18 15:21:14, dgozman wrote:
> I'd indent this with 3 more spaces.

Done.

https://chromiumcodereview.appspot.com/10556041/diff/1/chrome/browser/chromeo...
chrome/browser/chromeos/extensions/file_handler_util.cc:242: iter++;
On 2012/06/18 15:21:14, dgozman wrote:
> AFAIK, while body must be a block.

Done.

https://chromiumcodereview.appspot.com/10556041/diff/1/chrome/browser/chromeo...
File chrome/browser/chromeos/extensions/file_manager_util.h (right):

https://chromiumcodereview.appspot.com/10556041/diff/1/chrome/browser/chromeo...
chrome/browser/chromeos/extensions/file_manager_util.h:25: extern const char
kFileBrowserGalleryTaskId[];
They already exist in file_manager_util.cc (next to kFileBrowserDomain)
On 2012/06/18 15:21:14, dgozman wrote:
> Where are the definitions of these constants?

[dgozman, 2012-06-19 12:25:09]

LGTM