Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 10556038: Fix MSVC warning about missing operator delete. (Closed)

Created:
8 years, 6 months ago by sanjoy
Modified:
8 years, 6 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Fix MSVC warnings about missing operator delete. BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=11847

Patch Set 1 #

Total comments: 4

Patch Set 2 : Remove size_t argument from operator delete #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
M src/list.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/splay-tree.h View 1 2 chunks +11 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sanjoy
8 years, 6 months ago (2012-06-18 09:46:58 UTC) #1
Jakob Kummerow
http://codereview.chromium.org/10556038/diff/1/src/splay-tree.h File src/splay-tree.h (right): http://codereview.chromium.org/10556038/diff/1/src/splay-tree.h#newcode69 src/splay-tree.h:69: INLINE(void operator delete(void* p, size_t)) { "delete" operators don't ...
8 years, 6 months ago (2012-06-18 12:08:40 UTC) #2
sanjoy
Removed size_t arguments from operator delete.
8 years, 6 months ago (2012-06-18 12:24:18 UTC) #3
Jakob Kummerow
8 years, 6 months ago (2012-06-18 12:39:51 UTC) #4
LGTM. The Windows compiler seems to like it too.

Powered by Google App Engine
This is Rietveld 408576698