Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7499)

Unified Diff: chrome/browser/ui/views/accessibility/browser_views_accessibility_browsertest.cc

Issue 10556034: views: Get rid of DoShowAboutChromeDialog() function. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/about_chrome_view.cc ('k') | chrome/browser/ui/views/browser_dialogs.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/accessibility/browser_views_accessibility_browsertest.cc
diff --git a/chrome/browser/ui/views/accessibility/browser_views_accessibility_browsertest.cc b/chrome/browser/ui/views/accessibility/browser_views_accessibility_browsertest.cc
index e6b92870295e3310f56167590f22f3bd35cc88a2..b785f0012f3953343be175638162e3228d725e02 100644
--- a/chrome/browser/ui/views/accessibility/browser_views_accessibility_browsertest.cc
+++ b/chrome/browser/ui/views/accessibility/browser_views_accessibility_browsertest.cc
@@ -256,33 +256,3 @@ IN_PROC_BROWSER_TEST_F(BrowserViewsAccessibilityTest,
UTF16ToWide(l10n_util::GetStringUTF16(IDS_ACCNAME_BOOKMARKS)),
ROLE_SYSTEM_TOOLBAR);
}
-
-// http://crbug.com/114111
-IN_PROC_BROWSER_TEST_F(BrowserViewsAccessibilityTest,
- DISABLED_TestAboutChromeViewAccObj) {
- // Firstly, test that the WindowDelegate got updated.
- views::Widget* about_chrome_window =
- GetBrowserView()->DoShowAboutChromeDialog();
- EXPECT_STREQ(
- about_chrome_window->widget_delegate()->GetWindowTitle().c_str(),
- UTF16ToWide(l10n_util::GetStringUTF16(IDS_ABOUT_CHROME_TITLE)).c_str());
- EXPECT_EQ(about_chrome_window->widget_delegate()->GetAccessibleWindowRole(),
- ui::AccessibilityTypes::ROLE_DIALOG);
-
- // Also test the accessibility object directly.
- IAccessible* acc_obj = NULL;
- HRESULT hr =
- ::AccessibleObjectFromWindow(about_chrome_window->GetNativeWindow(),
- OBJID_CLIENT,
- IID_IAccessible,
- reinterpret_cast<void**>(&acc_obj));
- ASSERT_EQ(S_OK, hr);
- ASSERT_TRUE(NULL != acc_obj);
-
- TestAccessibilityInfo(
- acc_obj,
- UTF16ToWide(l10n_util::GetStringUTF16(IDS_ABOUT_CHROME_TITLE)),
- ROLE_SYSTEM_DIALOG);
-
- acc_obj->Release();
-}
« no previous file with comments | « chrome/browser/ui/views/about_chrome_view.cc ('k') | chrome/browser/ui/views/browser_dialogs.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698