Issue 10556034: views: Get rid of DoShowAboutChromeDialog() function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10556034: views: Get rid of DoShowAboutChromeDialog() function. (Closed)

Created:
8 years, 6 months ago by tfarina

Modified:
8 years, 6 months ago

Reviewers:
dmazzoni

CC:
chromium-reviews, hashimoto+watch_chromium.org, aboxhall+watch_chromium.org, yoshiki+watch_chromium.org, yuzo+watch_chromium.org, davidbarr+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, ctguil+watch_chromium.org, zork+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

views: Get rid of DoShowAboutChromeDialog() function. BUG=133118 R=dmazzoni@chromium.org TBR=pkasting@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=142709

Patch Set 1 #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -44 lines)			Patch
M	chrome/browser/ui/views/about_chrome_view.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/ui/views/accessibility/browser_views_accessibility_browsertest.cc	View	1 chunk	+0 lines, -30 lines	0 comments	Download
M	chrome/browser/ui/views/browser_dialogs.h	View	2 chunks	+1 line, -3 lines	0 comments	Download
M	chrome/browser/ui/views/frame/browser_view.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/views/frame/browser_view.cc	View	1 chunk	+2 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

tfarina

The patch I requested through email. Please, take a look.

8 years, 6 months ago (2012-06-18 02:14:03 UTC) #1

lgtm

Expand Messages | Collapse Messages