Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 10556031: views: Move autocomplete files into omnibox directory. (Closed)

Created:
8 years, 6 months ago by tfarina
Modified:
8 years, 6 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, James Su
Visibility:
Public.

Description

views: Move autocomplete files into omnibox directory. BUG=80186 R=pkasting@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=143033

Patch Set 1 #

Total comments: 4

Patch Set 2 : fix nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+256 lines, -1982 lines) Patch
D chrome/browser/ui/views/autocomplete/autocomplete_popup_contents_view.h View 1 chunk +0 lines, -191 lines 0 comments Download
D chrome/browser/ui/views/autocomplete/autocomplete_popup_contents_view.cc View 1 chunk +0 lines, -574 lines 0 comments Download
D chrome/browser/ui/views/autocomplete/autocomplete_result_view.h View 1 chunk +0 lines, -167 lines 0 comments Download
D chrome/browser/ui/views/autocomplete/autocomplete_result_view.cc View 1 chunk +0 lines, -638 lines 0 comments Download
D chrome/browser/ui/views/autocomplete/autocomplete_result_view_model.h View 1 chunk +0 lines, -26 lines 0 comments Download
D chrome/browser/ui/views/autocomplete/touch_autocomplete_popup_contents_view.h View 1 chunk +0 lines, -70 lines 0 comments Download
D chrome/browser/ui/views/autocomplete/touch_autocomplete_popup_contents_view.cc View 1 chunk +0 lines, -119 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.h View 6 chunks +19 lines, -19 lines 0 comments Download
A + chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc View 1 25 chunks +72 lines, -76 lines 0 comments Download
A + chrome/browser/ui/views/omnibox/omnibox_result_view.h View 5 chunks +13 lines, -13 lines 0 comments Download
A + chrome/browser/ui/views/omnibox/omnibox_result_view.cc View 14 chunks +33 lines, -37 lines 0 comments Download
A + chrome/browser/ui/views/omnibox/omnibox_result_view_model.h View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_views.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_win.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_win.cc View 1 chunk +1 line, -1 line 0 comments Download
A chrome/browser/ui/views/omnibox/touch_omnibox_popup_contents_view.h View 1 chunk +70 lines, -0 lines 0 comments Download
A + chrome/browser/ui/views/omnibox/touch_omnibox_popup_contents_view.cc View 1 3 chunks +30 lines, -33 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tfarina
8 years, 6 months ago (2012-06-16 20:39:36 UTC) #1
Peter Kasting
8 years, 6 months ago (2012-06-18 19:24:09 UTC) #2
LGTM.  Looks like touch_omnibox_popup_contents_view.h didn't get "moved" from
the old file (so it retains the original history and props) the way the others
did?

http://codereview.chromium.org/10556031/diff/1/chrome/browser/ui/views/omnibo...
File chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc (right):

http://codereview.chromium.org/10556031/diff/1/chrome/browser/ui/views/omnibo...
chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc:210:
OmniboxResultView* view = static_cast<OmniboxResultView*>(
Nit: This will now fit on one line.

http://codereview.chromium.org/10556031/diff/1/chrome/browser/ui/views/omnibo...
chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc:502:
OmniboxResultView::BACKGROUND), alpha), SkXfermode::kDstIn_Mode);
Nit: Indent 4 more

http://codereview.chromium.org/10556031/diff/1/chrome/browser/ui/views/omnibo...
File chrome/browser/ui/views/omnibox/touch_omnibox_popup_contents_view.cc
(right):

http://codereview.chromium.org/10556031/diff/1/chrome/browser/ui/views/omnibo...
chrome/browser/ui/views/omnibox/touch_omnibox_popup_contents_view.cc:63:
location_bar) {
Nit: On previous line

http://codereview.chromium.org/10556031/diff/1/chrome/browser/ui/views/omnibo...
chrome/browser/ui/views/omnibox/touch_omnibox_popup_contents_view.cc:89:
TouchOmniboxResultView* child =
Nit: This will now fit on one line, maybe next will too?

Powered by Google App Engine
This is Rietveld 408576698