Issue 10556030: mac: Fix close button appearance in HiDPI.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10556030: mac: Fix close button appearance in HiDPI. (Closed)

Created:
8 years, 6 months ago by Nico

Modified:
8 years, 6 months ago

Reviewers:
Robert Sesek

CC:
chromium-reviews

Base URL:
http://git.chromium.org/git/chromium.git@trunk

Visibility:
Public.

More Reviews

Description

mac: Fix close button appearance in HiDPI. Revert the explicit "scale" parts of r142304. In 10.7.3, the backing scale factor did not apply to shadowOffset and shadowBlurRadius. This appears fixed in 10.7.4, and retina MBPs ship with 10.7.4 -- so the manual scaling caused the scale to be applied twice, which moved the shadow off the close button. BUG=133134 TEST=look at a tab close button TBR=rsesek Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=142607

Patch Set 1 #

Patch Set 2 : . #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -6 lines)			Patch
M	chrome/browser/ui/cocoa/hover_close_button.mm	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	third_party/molokocacao/NSBezierPath+MCAdditions.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/molokocacao/NSBezierPath+MCAdditions.m	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	third_party/molokocacao/README.chromium	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

8 years, 6 months ago (2012-06-16 18:10:49 UTC) #3

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/10556030/2001

Expand Messages | Collapse Messages