DomStorageArea -> DomStorageDatabase indirection; add *StorageDatabaseAdapter.

webkit/dom_storage/dom_storage_database_adapter.h

Index: webkit/dom_storage/dom_storage_database_adapter.h
diff --git a/webkit/dom_storage/dom_storage_database_adapter.h b/webkit/dom_storage/dom_storage_database_adapter.h
new file mode 100644
index 0000000000000000000000000000000000000000..ea886ba1d4b96824b14ac7d713f1f99fc70c9edd
--- /dev/null
+++ b/webkit/dom_storage/dom_storage_database_adapter.h
@@ -0,0 +1,32 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef WEBKIT_DOM_STORAGE_DOM_STORAGE_DATABASE_ADAPTER_H_
+#define WEBKIT_DOM_STORAGE_DOM_STORAGE_DATABASE_ADAPTER_H_
+#pragma once
+
+// Database interface used by DomStorageArea. Abstracts the differences between
+// the per-origin DomStorageDatabases for localStorage and
+// SessionStorageDatabase which stores multiple origins.
+
+#include "webkit/dom_storage/dom_storage_types.h"
+
+namespace dom_storage {
+
+class DomStorageDatabaseAdapter {
+ public:
+  DomStorageDatabaseAdapter();

[michaeln, 2012/06/15 19:02:43]

is this ctor needed?

[marja, 2012/06/19 10:43:30]

No if DISALLOW_.. is removed. Removed the DISALLOW_.., removed this.

+  virtual ~DomStorageDatabaseAdapter();

[michaeln, 2012/06/15 19:02:43]

would an emtpy method body work here? if so we may not need the .cc file at all
for this interface.

[marja, 2012/06/19 10:43:30]

Done.

+  virtual void ReadAllValues(ValuesMap* result) = 0;
+  virtual bool CommitChanges(
+      bool clear_all_first, const ValuesMap& changes) = 0;
+  virtual void DeleteFiles() { }

[michaeln, 2012/06/15 19:02:43]

nit: no space required in {}

[marja, 2012/06/19 10:43:30]

Done.

+  virtual void Reset() { }
+
+  DISALLOW_COPY_AND_ASSIGN(DomStorageDatabaseAdapter);

[michaeln, 2012/06/15 19:02:43]

is this meaningful on an abstract class?

[marja, 2012/06/19 10:43:30]

Removed.

+};
+
+}  // namespace dom_storage
+
+#endif  // WEBKIT_DOM_STORAGE_DOM_STORAGE_DATABASE_ADAPTER_H_