Chromium Code Reviews
Help | Chromium Project | Sign in
(128)

Issue 10556004: Revert part of 11727 as it sometimes tanked V8 benchmark (raytrace) performance (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 2 months ago by Erik Corry
Modified:
3 years, 2 months ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Revert part of 11727 as it sometimes tanked V8 benchmark (raytrace) performance for reasons that are not obvious. Now we make objects into fast-case objects when they are made prototypes for other objects, but we do not mark objects that are already fast case with a bit that helps keep them in fast case. Committed: https://code.google.com/p/v8/source/detail?r=11831

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -66 lines) Patch
M src/objects.h View 3 chunks +1 line, -12 lines 0 comments Download
M src/objects.cc View 2 chunks +7 lines, -30 lines 0 comments Download
M src/objects-inl.h View 2 chunks +1 line, -16 lines 0 comments Download
M test/cctest/test-heap.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M test/mjsunit/fast-prototype.js View 1 chunk +2 lines, -2 lines 0 comments Download
Trybot results:
Project "None" does not have a commit queue.

Messages

Total messages: 2 (0 generated)
Erik Corry
3 years, 2 months ago (2012-06-15 11:18:22 UTC) #1
ulan
3 years, 2 months ago (2012-06-15 11:42:18 UTC) #2
LGTM (rubber-stamp).

Could you please add to the description that it is a partial revert?

I checked that it fixed the raytrace regression on my machine.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 020f378