Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Unified Diff: content/public/browser/browser_ppapi_host.h

Issue 105553005: Make PepperWebPlugin not use RenderViews. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: review comments Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/common/view_messages.h ('k') | content/public/browser/render_frame_host.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/browser/browser_ppapi_host.h
===================================================================
--- content/public/browser/browser_ppapi_host.h (revision 242033)
+++ content/public/browser/browser_ppapi_host.h (working copy)
@@ -36,7 +36,7 @@
public:
struct OnKeepaliveInstanceStruct {
int render_process_id;
- int render_view_id;
+ int render_frame_id;
GURL document_url;
};
typedef std::vector<OnKeepaliveInstanceStruct> OnKeepaliveInstanceData;
@@ -67,7 +67,7 @@
// Returns true if the given PP_Instance is valid.
virtual bool IsValidInstance(PP_Instance instance) const = 0;
- // Retrieves the process/view Ids associated with the RenderView containing
+ // Retrieves the process/frame Ids associated with the RenderFrame containing
// the given instance and returns true on success. If the instance is
// invalid, the ids will be 0 and false will be returned.
//
@@ -75,10 +75,10 @@
// validated, and the resource hosts will be deleted when the resource is
// destroyed. So it should not generally be necessary to check for errors
// from this function except as a last-minute sanity check if you convert the
- // IDs to a RenderView/ProcessHost on the UI thread.
- virtual bool GetRenderViewIDsForInstance(PP_Instance instance,
- int* render_process_id,
- int* render_view_id) const = 0;
+ // IDs to a RenderFrame/ProcessHost on the UI thread.
+ virtual bool GetRenderFrameIDsForInstance(PP_Instance instance,
+ int* render_process_id,
+ int* render_frame_id) const = 0;
// Returns the name of the plugin.
virtual const std::string& GetPluginName() = 0;
« no previous file with comments | « content/common/view_messages.h ('k') | content/public/browser/render_frame_host.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698