Issue 10555034: Fix parse error on dead code in a switch statement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10555034: Fix parse error on dead code in a switch statement (Closed)

Created:
8 years, 6 months ago by zundel

Modified:
8 years, 6 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org, Brian Wilkerson

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix parse error on dead code in a switch statement http://code.google.com/p/dart/issues/detail?id=2149 Committed: https://code.google.com/p/dart/source/detail?r=8822

Patch Set 1 : # #

Total comments: 1

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+130 lines, -40 lines)			Patch
M	compiler/java/com/google/dart/compiler/parser/DartParser.java	View	6 chunks	+84 lines, -35 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/parser/ParserErrorCode.java	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/parser/SyntaxTest.java	View	2 chunks	+40 lines, -1 line	0 comments	Download
M	tests/co19/co19-compiler.status	View	1 chunk	+4 lines, -4 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

scheglov

8 years, 6 months ago (2012-06-18 20:45:49 UTC) #2

LGTM

https://chromiumcodereview.appspot.com/10555034/diff/4001/tests/co19/co19-com...
File tests/co19/co19-compiler.status (right):

https://chromiumcodereview.appspot.com/10555034/diff/4001/tests/co19/co19-com...
tests/co19/co19-compiler.status:131: #Language/11_Statements/11_Labels_A01_t01:
Fail # Issue 2440
Remove these lines?

Expand Messages | Collapse Messages