Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 10555029: Browser Plugin: Move to old directories (Closed)

Created:
8 years, 6 months ago by Fady Samuel
Modified:
8 years, 6 months ago
Reviewers:
jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch-content_chromium.org
Visibility:
Public.

Description

Browser Plugin: Move to old directories A new implementation is coming but this current implementation is still in use. Moving the current implementation to old directories to make it easy to get rid of once the new implementation has been upstreamed. BUG=none TEST=manually, browser plugin continues to work. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=142743

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -1641 lines) Patch
D content/browser/browser_plugin/browser_plugin_host.h View 1 chunk +0 lines, -129 lines 0 comments Download
D content/browser/browser_plugin/browser_plugin_host.cc View 1 chunk +0 lines, -227 lines 0 comments Download
D content/browser/browser_plugin/browser_plugin_host_helper.h View 1 chunk +0 lines, -50 lines 0 comments Download
D content/browser/browser_plugin/browser_plugin_host_helper.cc View 1 chunk +0 lines, -61 lines 0 comments Download
A + content/browser/browser_plugin/old/browser_plugin_host.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/browser_plugin/old/browser_plugin_host.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + content/browser/browser_plugin/old/browser_plugin_host_helper.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/browser_plugin/old/browser_plugin_host_helper.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/content_browser.gypi View 1 chunk +4 lines, -4 lines 0 comments Download
M content/content_renderer.gypi View 1 chunk +12 lines, -12 lines 0 comments Download
D content/renderer/browser_plugin/browser_plugin.h View 1 chunk +0 lines, -90 lines 0 comments Download
D content/renderer/browser_plugin/browser_plugin.cc View 1 chunk +0 lines, -157 lines 0 comments Download
D content/renderer/browser_plugin/browser_plugin_channel_manager.h View 1 chunk +0 lines, -82 lines 0 comments Download
D content/renderer/browser_plugin/browser_plugin_channel_manager.cc View 1 chunk +0 lines, -144 lines 0 comments Download
D content/renderer/browser_plugin/browser_plugin_constants.h View 1 chunk +0 lines, -15 lines 0 comments Download
D content/renderer/browser_plugin/browser_plugin_constants.cc View 1 chunk +0 lines, -10 lines 0 comments Download
D content/renderer/browser_plugin/browser_plugin_registry.h View 1 chunk +0 lines, -37 lines 0 comments Download
D content/renderer/browser_plugin/browser_plugin_registry.cc View 1 chunk +0 lines, -45 lines 0 comments Download
D content/renderer/browser_plugin/browser_plugin_var_serialization_rules.h View 1 chunk +0 lines, -35 lines 0 comments Download
D content/renderer/browser_plugin/browser_plugin_var_serialization_rules.cc View 1 chunk +0 lines, -51 lines 0 comments Download
D content/renderer/browser_plugin/guest_to_embedder_channel.h View 1 chunk +0 lines, -138 lines 0 comments Download
D content/renderer/browser_plugin/guest_to_embedder_channel.cc View 1 chunk +0 lines, -306 lines 0 comments Download
A + content/renderer/browser_plugin/old/browser_plugin.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/renderer/browser_plugin/old/browser_plugin.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/renderer/browser_plugin/old/browser_plugin_channel_manager.h View 1 chunk +3 lines, -3 lines 0 comments Download
A + content/renderer/browser_plugin/old/browser_plugin_channel_manager.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + content/renderer/browser_plugin/old/browser_plugin_constants.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/renderer/browser_plugin/old/browser_plugin_constants.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/renderer/browser_plugin/old/browser_plugin_registry.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/renderer/browser_plugin/old/browser_plugin_registry.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/renderer/browser_plugin/old/browser_plugin_var_serialization_rules.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/renderer/browser_plugin/old/browser_plugin_var_serialization_rules.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/renderer/browser_plugin/old/guest_to_embedder_channel.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/renderer/browser_plugin/old/guest_to_embedder_channel.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/renderer/pepper/pepper_plugin_delegate_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Fady Samuel
Hi John, I'm moving the browser plugin code to old directories as we've discussed. Please ...
8 years, 6 months ago (2012-06-18 15:23:20 UTC) #1
jam
lgtm
8 years, 6 months ago (2012-06-18 15:49:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/10555029/1
8 years, 6 months ago (2012-06-18 15:50:50 UTC) #3
commit-bot: I haz the power
8 years, 6 months ago (2012-06-18 17:15:59 UTC) #4
Change committed as 142743

Powered by Google App Engine
This is Rietveld 408576698