Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: ui/web_dialogs/constrained_web_dialog_ui.h

Issue 10554010: Remove BrowserList::GetLastActive usage from WebUI pages. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: review comments Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/data/webui/certificate_viewer_ui_test-inl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/web_dialogs/constrained_web_dialog_ui.h
===================================================================
--- ui/web_dialogs/constrained_web_dialog_ui.h (revision 142088)
+++ ui/web_dialogs/constrained_web_dialog_ui.h (working copy)
@@ -13,7 +13,6 @@
class ConstrainedWindow;
class Profile;
class TabContents;
-typedef TabContents TabContentsWrapper;
class WebDialogWebContentsDelegate;
namespace base {
@@ -42,10 +41,12 @@
virtual void ReleaseTabContentsOnDialogClose() = 0;
// Returns the ConstrainedWindow.
+ // TODO: fix this function name and the one below to conform to the style
+ // guide (i.e. GetWindow, GetTab).
virtual ConstrainedWindow* window() = 0;
- // Returns the TabContentsWrapper owned by the constrained window.
- virtual TabContentsWrapper* tab() = 0;
+ // Returns the TabContents owned by the constrained window.
+ virtual TabContents* tab() = 0;
protected:
virtual ~ConstrainedWebDialogDelegate() {}
@@ -100,7 +101,7 @@
Profile* profile,
WebDialogDelegate* delegate,
WebDialogWebContentsDelegate* tab_delegate,
- TabContentsWrapper* overshadowed);
+ TabContents* overshadowed);
} // namespace ui
« no previous file with comments | « chrome/test/data/webui/certificate_viewer_ui_test-inl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698