Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6705)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/webui/feedback_ui.cc

Issue 10554010: Remove BrowserList::GetLastActive usage from WebUI pages. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: review comments Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/certificate_viewer_webui.cc ('k') | chrome/browser/ui/webui/options2/certificate_manager_handler2.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/feedback_ui.cc
===================================================================
--- chrome/browser/ui/webui/feedback_ui.cc (revision 142088)
+++ chrome/browser/ui/webui/feedback_ui.cc (working copy)
@@ -21,7 +21,7 @@
#include "chrome/browser/feedback/feedback_util.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/browser.h"
-#include "chrome/browser/ui/browser_list.h"
+#include "chrome/browser/ui/browser_finder.h"
#include "chrome/browser/ui/browser_window.h"
#include "chrome/browser/ui/tab_contents/tab_contents.h"
#include "chrome/browser/ui/webui/chrome_url_data_manager.h"
@@ -358,9 +358,8 @@
}
#endif
- // TODO(beng): Replace GetLastActive with a more specific method of locating
- // the target contents.
- Browser* browser = BrowserList::GetLastActive();
+ Browser* browser =
+ browser::FindBrowserWithWebContents(web_ui()->GetWebContents());
// Sanity checks.
if (((index == 0) && (index_str != "0")) || !browser ||
index >= browser->tab_count()) {
« no previous file with comments | « chrome/browser/ui/webui/certificate_viewer_webui.cc ('k') | chrome/browser/ui/webui/options2/certificate_manager_handler2.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698