Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Side by Side Diff: chrome/browser/ui/browser_window.h

Issue 10554010: Remove BrowserList::GetLastActive usage from WebUI pages. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: review comments Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/ui/browser_list.h ('k') | chrome/browser/ui/cocoa/browser_window_cocoa.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_BROWSER_WINDOW_H_ 5 #ifndef CHROME_BROWSER_UI_BROWSER_WINDOW_H_
6 #define CHROME_BROWSER_UI_BROWSER_WINDOW_H_ 6 #define CHROME_BROWSER_UI_BROWSER_WINDOW_H_
7 #pragma once 7 #pragma once
8 8
9 #include "base/callback_forward.h" 9 #include "base/callback_forward.h"
10 #include "chrome/browser/lifetime/application_lifetime.h" 10 #include "chrome/browser/lifetime/application_lifetime.h"
(...skipping 267 matching lines...) Expand 10 before | Expand all | Expand 10 after
278 virtual int GetExtraRenderViewHeight() const = 0; 278 virtual int GetExtraRenderViewHeight() const = 0;
279 279
280 // Notification that |contents| got the focus through user action (click 280 // Notification that |contents| got the focus through user action (click
281 // on the page). 281 // on the page).
282 virtual void WebContentsFocused(content::WebContents* contents) = 0; 282 virtual void WebContentsFocused(content::WebContents* contents) = 0;
283 283
284 // Shows the page info using the specified information. 284 // Shows the page info using the specified information.
285 // |url| is the url of the page/frame the info applies to, |ssl| is the SSL 285 // |url| is the url of the page/frame the info applies to, |ssl| is the SSL
286 // information for that page/frame. If |show_history| is true, a section 286 // information for that page/frame. If |show_history| is true, a section
287 // showing how many times that URL has been visited is added to the page info. 287 // showing how many times that URL has been visited is added to the page info.
288 virtual void ShowPageInfo(Profile* profile, 288 virtual void ShowPageInfo(content::WebContents* web_contents,
289 const GURL& url, 289 const GURL& url,
290 const content::SSLStatus& ssl, 290 const content::SSLStatus& ssl,
291 bool show_history) = 0; 291 bool show_history) = 0;
292 292
293 // Shows the website settings using the specified information. |url| is the 293 // Shows the website settings using the specified information. |url| is the
294 // url of the page/frame the info applies to, |ssl| is the SSL information for 294 // url of the page/frame the info applies to, |ssl| is the SSL information for
295 // that page/frame. If |show_history| is true, a section showing how many 295 // that page/frame. If |show_history| is true, a section showing how many
296 // times that URL has been visited is added to the page info. 296 // times that URL has been visited is added to the page info.
297 virtual void ShowWebsiteSettings(Profile* profile, 297 virtual void ShowWebsiteSettings(Profile* profile,
298 TabContents* tab_contents, 298 TabContents* tab_contents,
(...skipping 127 matching lines...) Expand 10 before | Expand all | Expand 10 after
426 426
427 // Returns the ToolbarView. 427 // Returns the ToolbarView.
428 virtual ToolbarView* GetToolbarView() const = 0; 428 virtual ToolbarView* GetToolbarView() const = 0;
429 #endif 429 #endif
430 430
431 protected: 431 protected:
432 virtual ~BrowserWindowTesting() {} 432 virtual ~BrowserWindowTesting() {}
433 }; 433 };
434 434
435 #endif // CHROME_BROWSER_UI_BROWSER_WINDOW_H_ 435 #endif // CHROME_BROWSER_UI_BROWSER_WINDOW_H_
OLDNEW
« no previous file with comments | « chrome/browser/ui/browser_list.h ('k') | chrome/browser/ui/cocoa/browser_window_cocoa.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698