Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Side by Side Diff: chrome/browser/ui/browser_list.h

Issue 10554010: Remove BrowserList::GetLastActive usage from WebUI pages. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: review comments Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/ui/browser.cc ('k') | chrome/browser/ui/browser_window.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_BROWSER_LIST_H_ 5 #ifndef CHROME_BROWSER_UI_BROWSER_LIST_H_
6 #define CHROME_BROWSER_UI_BROWSER_LIST_H_ 6 #define CHROME_BROWSER_UI_BROWSER_LIST_H_
7 #pragma once 7 #pragma once
8 8
9 #include <vector> 9 #include <vector>
10 10
(...skipping 90 matching lines...) Expand 10 before | Expand all | Expand 10 after
101 static bool IsOffTheRecordSessionActive(); 101 static bool IsOffTheRecordSessionActive();
102 102
103 // Returns true if at least one incognito session is active for |profile|. 103 // Returns true if at least one incognito session is active for |profile|.
104 static bool IsOffTheRecordSessionActiveForProfile(Profile* profile); 104 static bool IsOffTheRecordSessionActiveForProfile(Profile* profile);
105 105
106 private: 106 private:
107 // DO NOT ADD MORE FRIENDS TO THIS LIST. This list should be reduced over 107 // DO NOT ADD MORE FRIENDS TO THIS LIST. This list should be reduced over
108 // time by wiring context through to the relevant code rather than using 108 // time by wiring context through to the relevant code rather than using
109 // GetLastActive(). 109 // GetLastActive().
110 friend class BrowserView; 110 friend class BrowserView;
111 friend class CertificateViewerDialog;
112 friend class ChromeShellDelegate; 111 friend class ChromeShellDelegate;
113 friend class ExtensionInstallDialogView; 112 friend class ExtensionInstallDialogView;
114 friend class FeedbackHandler;
115 friend class GtkThemeService; 113 friend class GtkThemeService;
116 friend class NetworkProfileBubble; 114 friend class NetworkProfileBubble;
117 friend class PrintPreviewHandler; 115 friend class PrintPreviewHandler;
118 friend class QueryTabsFunction; 116 friend class QueryTabsFunction;
119 friend class SelectFileDialogExtension; 117 friend class SelectFileDialogExtension;
120 friend class StartupBrowserCreatorImpl; 118 friend class StartupBrowserCreatorImpl;
121 friend class TaskManager; 119 friend class TaskManager;
122 friend class TestingAutomationProvider; 120 friend class TestingAutomationProvider;
123 friend class WindowSizer; 121 friend class WindowSizer;
124 friend class browser::BrowserActivityObserver; 122 friend class browser::BrowserActivityObserver;
(...skipping 28 matching lines...) Expand all
153 // WARNING #2: this will always be NULL in unit tests run on the bots. 151 // WARNING #2: this will always be NULL in unit tests run on the bots.
154 // THIS FUNCTION IS PRIVATE AND NOT TO BE USED AS A REPLACEMENT FOR RELEVANT 152 // THIS FUNCTION IS PRIVATE AND NOT TO BE USED AS A REPLACEMENT FOR RELEVANT
155 // CONTEXT. 153 // CONTEXT.
156 static Browser* GetLastActive(); 154 static Browser* GetLastActive();
157 155
158 // Helper method to remove a browser instance from a list of browsers 156 // Helper method to remove a browser instance from a list of browsers
159 static void RemoveBrowserFrom(Browser* browser, BrowserVector* browser_list); 157 static void RemoveBrowserFrom(Browser* browser, BrowserVector* browser_list);
160 }; 158 };
161 159
162 #endif // CHROME_BROWSER_UI_BROWSER_LIST_H_ 160 #endif // CHROME_BROWSER_UI_BROWSER_LIST_H_
OLDNEW
« no previous file with comments | « chrome/browser/ui/browser.cc ('k') | chrome/browser/ui/browser_window.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698