Move content::URLFetcher static functions to net::URLFetcher

Move content::URLFetcher static functions to net::URLFetcher

Remove content::URLFetcher.

Update all references.

Add explicit dependency on content_common from browser, since template_url_fetcher.cc calls AssociateURLFetcherWithRenderView
(there are probably other direct uses of content_common).

BUG=118220
TEST=
TBR=satorux@chromium.org,mnissler@chromium.org,mal@chromium.org,jhawkins@chromium.org,sky@chromium.org,rlp@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=142926

[akalin, 2012-06-15 19:30:20]

+wtc for review
+jam for content owners

I'll TBR everyone else for owners.

[jam, 2012-06-15 19:52:04]

content lgtm

http://codereview.chromium.org/10554008/diff/2001/content/public/common/url_f...
File content/public/common/url_fetcher.h (right):

http://codereview.chromium.org/10554008/diff/2001/content/public/common/url_f...
content/public/common/url_fetcher.h:27: // TODO(akalin): Remove this block once
rlz is updated to use
:( i've started a thread on cr-dev about this :)

[akalin, 2012-06-18 16:54:59]

wtc, ping!

this is the last (non-test) patch for the migration. :)

[wtc, 2012-06-18 23:04:21]

Patch set 3 LGTM.  Thanks.

Just some questions and what looks like a stale comment in the
CL's description.

http://codereview.chromium.org/10554008/diff/75/chrome/chrome_browser.gypi
File chrome/chrome_browser.gypi (right):

http://codereview.chromium.org/10554008/diff/75/chrome/chrome_browser.gypi#ne...
chrome/chrome_browser.gypi:37: '../content/content.gyp:content_common',

What is this new dependency for?  Just curious.

http://codereview.chromium.org/10554008/diff/75/content/common/net/url_fetche...
File content/common/net/url_fetcher.cc (right):

http://codereview.chromium.org/10554008/diff/75/content/common/net/url_fetche...
content/common/net/url_fetcher.cc:1: // Copyright (c) 2012 The Chromium Authors.
All rights reserved.

The CL's description says:
  Move content/common/net/url_fetcher.cc to content/public/common.

But this file isn't moved.  Perhaps the CL's description is
out of date?

http://codereview.chromium.org/10554008/diff/75/content/common/net/url_fetche...
content/common/net/url_fetcher.cc:13: namespace URLFetcher {

This doesn't confirm to our Style Guide?  All the namespace names
I have seen are all lowercase.  I guess the URLFetcher
namespace is just a temporary solution to the rlz problem?

[akalin, 2012-06-18 23:12:32]

Addressed all comments, committing

http://codereview.chromium.org/10554008/diff/75/chrome/chrome_browser.gypi
File chrome/chrome_browser.gypi (right):

http://codereview.chromium.org/10554008/diff/75/chrome/chrome_browser.gypi#ne...
chrome/chrome_browser.gypi:37: '../content/content.gyp:content_common',
On 2012/06/18 23:04:22, wtc wrote:
> 
> What is this new dependency for?  Just curious.

template_url_fetcher.cc uses AssociateURLFetcherWIthRenderView, which is in
content_common.  It works fine without this line, probably because
content_browser pulls it in, but I think it's better to explicitly specify it.

Updated CL description

http://codereview.chromium.org/10554008/diff/75/content/common/net/url_fetche...
File content/common/net/url_fetcher.cc (right):

http://codereview.chromium.org/10554008/diff/75/content/common/net/url_fetche...
content/common/net/url_fetcher.cc:1: // Copyright (c) 2012 The Chromium Authors.
All rights reserved.
On 2012/06/18 23:04:22, wtc wrote:
> 
> The CL's description says:
>   Move content/common/net/url_fetcher.cc to content/public/common.
> 
> But this file isn't moved.  Perhaps the CL's description is
> out of date?

Yeah, you're right.  Fixed.

http://codereview.chromium.org/10554008/diff/75/content/common/net/url_fetche...
content/common/net/url_fetcher.cc:13: namespace URLFetcher {
On 2012/06/18 23:04:22, wtc wrote:
> 
> This doesn't confirm to our Style Guide?  All the namespace names
> I have seen are all lowercase.  I guess the URLFetcher
> namespace is just a temporary solution to the rlz problem?

Yeah, it's just a temporary hack.  It should go away quickly once this gets
checked in. (thakis promised to fix rlz once I ping him.)

[commit-bot: I haz the power, 2012-06-18 23:16:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/akalin@chromium.org/10554008/75

[commit-bot: I haz the power, 2012-06-18 23:17:28]

Presubmit check for 10554008-75 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome/browser/chromeos/gdata
    chrome/browser/policy
    chrome/browser/component_updater
    chrome/browser/ui/intents
    chrome/browser/search_engines
    chrome/browser/profiles

Presubmit checks took 4.9s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[commit-bot: I haz the power, 2012-06-18 23:20:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/akalin@chromium.org/10554008/75

[commit-bot: I haz the power, 2012-06-19 00:25:38]

Try job failure for 10554008-75 (retry) on win for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

[commit-bot: I haz the power, 2012-06-19 06:55:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/akalin@chromium.org/10554008/23004