Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 10553038: Merge 142347 - HiDPI: Fix extension bubble size (Closed)

Created:
8 years, 6 months ago by Nico
Modified:
8 years, 6 months ago
Reviewers:
sail
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org
Visibility:
Public.

Description

Merge 142347 - HiDPI: Fix extension bubble size The size of extension bubbles was wrong in HiDPI mode. The problem was that we were using convertRectToBase. As per Avi's PSA, we should be using convertRect:ToView:. See: https://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thread/6b989dcbb79e9ba/029eeb633c5287cc I did a search and it looks like we made the same mistake in the tab dragging code. Before my fix it was impossible to drag a tab from one window to the right of a tab in another window. This fixes that as well. BUG=132762 TEST=Ran in HiDPI mode on 10.7. Without my fix the extension bubble was 4x the normal size. With my fix the extension bubble was correctly 2x the normal size. Review URL: https://chromiumcodereview.appspot.com/10540173 TBR=sail@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=142719

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/ui/cocoa/browser_window_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
Nico
8 years, 6 months ago (2012-06-18 15:57:08 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698