Stop mapping indexOf/lastIndexOf directly to the JavaScript native on indexable primitives.

lib/compiler/implementation/ssa/codegen.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class SsaCodeGeneratorTask extends CompilerTask {
   final JavaScriptBackend backend;
   SsaCodeGeneratorTask(JavaScriptBackend backend)
       : this.backend = backend,
         super(backend.compiler);
   String get name() => 'SSA code generator';
@@ skipping 2108 matching lines @@
       use(node.inputs[2], JSPrecedence.EXPRESSION_PRECEDENCE);
       buffer.add('] = ');
       use(node.inputs[3], JSPrecedence.ASSIGNMENT_PRECEDENCE);
       endExpression(JSPrecedence.ASSIGNMENT_PRECEDENCE);
     } else {
       visitInvokeStatic(node);
     }
   }
 
   String builtinJsName(HInvokeInterceptor interceptor) {
+    // Don't count the target method or the receiver in the arity.
+    int arity = interceptor.inputs.length - 2;
     HInstruction receiver = interceptor.inputs[1];
     bool getter = interceptor.getter;
     SourceString name = interceptor.name;
 
-    if (receiver.isIndexablePrimitive()) {
-      if (interceptor.isLengthGetter()) {
-        return 'length';
-      } else if (!getter
-                 && name == const SourceString('indexOf')
-                 && interceptor.inputs.length == 3) {
-        // If there are three inputs, the start index is not given,
-        // and we share the same default value with the native
-        // implementation.
-        return 'indexOf';
-      } else if (!getter
-                 && name == const SourceString('lastIndexOf')
-                 && interceptor.inputs.length == 3) {
-        // If there are three inputs, the start index is not given,
-        // and we share the same default value with the native
-        // implementation.
-        return 'lastIndexOf';
-      }
-    }
-
-    if (receiver.isExtendableArray() && !getter) {
-      if (name == const SourceString('add')) {
+    if (interceptor.isLengthGetterOnStringOrArray()) {
+      return 'length';
+    } else if (receiver.isExtendableArray() && !getter) {
+      if (name == const SourceString('add') && arity == 1) {
         return 'push';
       }
-      if (name == const SourceString('removeLast')) {
+      if (name == const SourceString('removeLast') && arity == 0) {
         return 'pop';
       }
-    }
-
-    if (receiver.isString() && !getter) {
-      if (name == const SourceString('concat')
-          && interceptor.inputs[2].isString()) {
+    } else if (receiver.isString() && !getter) {
+      if (name == const SourceString('concat') &&
+          arity == 1 &&
+          interceptor.inputs[2].isString()) {
         return '+';
       }
     }
 
     return null;
   }
 
   void visitInvokeInterceptor(HInvokeInterceptor node) {
     String builtin = builtinJsName(node);
     if (builtin !== null) {
@@ skipping 737 matching lines @@
       startBailoutSwitch();
     }
   }
 
   void endLabeledBlock(HLabeledBlockInformation labeledBlockInfo) {
     if (labeledBlockInfo.body.start.hasGuards()) {
       endBailoutSwitch();
     }
   }
 }