Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Unified Diff: dart/lib/compiler/implementation/operations.dart

Issue 10553007: Remove support for String operator + from dart2js. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Update co19 status Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dart/lib/compiler/implementation/operations.dart
diff --git a/dart/lib/compiler/implementation/operations.dart b/dart/lib/compiler/implementation/operations.dart
index 3bd11b8b52bcbd2d19d6b989e7d1d3cc50d5e3c7..0fb34cb6d6513145fab4d2d01d3292855487c744 100644
--- a/dart/lib/compiler/implementation/operations.dart
+++ b/dart/lib/compiler/implementation/operations.dart
@@ -228,19 +228,6 @@ class AddOperation implements BinaryOperation {
NumConstant leftNum = left;
NumConstant rightNum = right;
return new DoubleConstant(leftNum.value + rightNum.value);
- } else if (left.isString() && !right.isObject()) {
- PrimitiveConstant primitiveRight = right;
- DartString rightDartString = primitiveRight.toDartString();
- StringConstant leftString = left;
- if (rightDartString.isEmpty()) {
- return left;
- } else if (leftString.value.isEmpty()) {
- return new StringConstant(rightDartString, leftString.node);
- } else {
- DartString concatenated =
- new ConsDartString(leftString.value, rightDartString);
- return new StringConstant(concatenated, leftString.node);
- }
} else {
return null;
}

Powered by Google App Engine
This is Rietveld 408576698