Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5187)

Unified Diff: chrome/browser/ui/pdf/pdf_browsertest.cc

Issue 10551002: TabContentsWrapper -> TabContents, part 56. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Not killing GetSelectedWebContents yet Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/pdf/pdf_browsertest.cc
diff --git a/chrome/browser/ui/pdf/pdf_browsertest.cc b/chrome/browser/ui/pdf/pdf_browsertest.cc
index bbeed83f939cabc95c8ce1b80a5f7bbb42841d0c..bcc5c9548e796e6dd1efeb16c881abd7524c4aba 100644
--- a/chrome/browser/ui/pdf/pdf_browsertest.cc
+++ b/chrome/browser/ui/pdf/pdf_browsertest.cc
@@ -10,7 +10,7 @@
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_window.h"
#include "chrome/browser/ui/snapshot_tab_helper.h"
-#include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h"
+#include "chrome/browser/ui/tab_contents/tab_contents.h"
#include "chrome/common/chrome_notification_types.h"
#include "chrome/common/chrome_paths.h"
#include "chrome/test/base/in_process_browser_test.h"
@@ -83,12 +83,12 @@ class PDFBrowserTest : public InProcessBrowserTest,
void VerifySnapshot(const std::string& expected_filename) {
snapshot_different_ = true;
expected_filename_ = expected_filename;
- TabContentsWrapper* wrapper = browser()->GetSelectedTabContentsWrapper();
- wrapper->snapshot_tab_helper()->CaptureSnapshot();
+ TabContents* tab_contents = browser()->GetActiveTabContents();
+ tab_contents->snapshot_tab_helper()->CaptureSnapshot();
ui_test_utils::RegisterAndWait(
this,
chrome::NOTIFICATION_TAB_SNAPSHOT_TAKEN,
- content::Source<WebContents>(wrapper->web_contents()));
+ content::Source<WebContents>(tab_contents->web_contents()));
ASSERT_FALSE(snapshot_different_) << "Rendering didn't match, see result "
"at " << snapshot_filename_.value().c_str();
}
@@ -107,7 +107,7 @@ class PDFBrowserTest : public InProcessBrowserTest,
string16 query = UTF8ToUTF16(
std::string("xyzxyz" + base::IntToString(next_dummy_search_value_++)));
ASSERT_EQ(0, ui_test_utils::FindInPage(
- browser()->GetSelectedTabContentsWrapper(), query, true, false, NULL));
+ browser()->GetActiveTabContents(), query, true, false, NULL));
}
private:
@@ -237,13 +237,13 @@ IN_PROC_BROWSER_TEST_F(PDFBrowserTest, MAYBE_Scroll) {
wheel_event.type = WebKit::WebInputEvent::MouseWheel;
wheel_event.deltaY = -200;
wheel_event.wheelTicksY = -2;
- WebContents* web_contents = browser()->GetSelectedWebContents();
+ WebContents* web_contents = browser()->GetActiveWebContents();
web_contents->GetRenderViewHost()->ForwardWheelEvent(wheel_event);
ASSERT_NO_FATAL_FAILURE(WaitForResponse());
int y_offset = 0;
ASSERT_TRUE(ui_test_utils::ExecuteJavaScriptAndExtractInt(
- browser()->GetSelectedWebContents()->GetRenderViewHost(),
+ browser()->GetActiveWebContents()->GetRenderViewHost(),
std::wstring(),
L"window.domAutomationController.send(plugin.pageYOffset())",
&y_offset));
@@ -260,7 +260,7 @@ IN_PROC_BROWSER_TEST_F(PDFBrowserTest, MAYBE_FindAndCopy) {
ASSERT_NO_FATAL_FAILURE(Load());
// Verifies that find in page works.
ASSERT_EQ(3, ui_test_utils::FindInPage(
- browser()->GetSelectedTabContentsWrapper(), UTF8ToUTF16("adipiscing"),
+ browser()->GetActiveTabContents(), UTF8ToUTF16("adipiscing"),
true, false, NULL));
// Verify that copying selected text works.
@@ -272,7 +272,7 @@ IN_PROC_BROWSER_TEST_F(PDFBrowserTest, MAYBE_FindAndCopy) {
objects[ui::Clipboard::CBF_TEXT] = params;
clipboard.WriteObjects(ui::Clipboard::BUFFER_STANDARD, objects);
- browser()->GetSelectedWebContents()->GetRenderViewHost()->Copy();
+ browser()->GetActiveWebContents()->GetRenderViewHost()->Copy();
ASSERT_NO_FATAL_FAILURE(WaitForResponse());
std::string text;
@@ -288,7 +288,7 @@ IN_PROC_BROWSER_TEST_F(PDFBrowserTest, SLOW_Loading) {
ASSERT_TRUE(pdf_test_server()->Start());
NavigationController* controller =
- &(browser()->GetSelectedWebContents()->GetController());
+ &(browser()->GetActiveWebContents()->GetController());
content::NotificationRegistrar registrar;
registrar.Add(this,
content::NOTIFICATION_LOAD_STOP,
@@ -323,7 +323,7 @@ IN_PROC_BROWSER_TEST_F(PDFBrowserTest, SLOW_Loading) {
// and before creating a byte-range request loader.
bool complete = false;
ASSERT_TRUE(ui_test_utils::ExecuteJavaScriptAndExtractBool(
- browser()->GetSelectedWebContents()->GetRenderViewHost(),
+ browser()->GetActiveWebContents()->GetRenderViewHost(),
std::wstring(),
L"window.domAutomationController.send(plugin.documentLoadComplete())",
&complete));
@@ -334,7 +334,7 @@ IN_PROC_BROWSER_TEST_F(PDFBrowserTest, SLOW_Loading) {
// nested message loop for the JS call.
if (last_count != load_stop_notification_count())
continue;
- ui_test_utils::WaitForLoadStop(browser()->GetSelectedWebContents());
+ ui_test_utils::WaitForLoadStop(browser()->GetActiveWebContents());
}
}
}
@@ -349,14 +349,14 @@ IN_PROC_BROWSER_TEST_F(PDFBrowserTest, DISABLED_OnLoadAndReload) {
ui_test_utils::WindowedNotificationObserver observer(
content::NOTIFICATION_LOAD_STOP,
content::Source<NavigationController>(
- &browser()->GetSelectedWebContents()->GetController()));
+ &browser()->GetActiveWebContents()->GetController()));
ASSERT_TRUE(ui_test_utils::ExecuteJavaScript(
- browser()->GetSelectedWebContents()->GetRenderViewHost(),
+ browser()->GetActiveWebContents()->GetRenderViewHost(),
std::wstring(),
L"reloadPDF();"));
observer.Wait();
- ASSERT_EQ("success", browser()->GetSelectedWebContents()->GetURL().query());
+ ASSERT_EQ("success", browser()->GetActiveWebContents()->GetURL().query());
}
} // namespace
« no previous file with comments | « chrome/browser/ui/panels/old_panel_browsertest.cc ('k') | chrome/browser/ui/sync/browser_synced_window_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698