chrome/browser/custom_handlers/protocol_handler_registry_browsertest.cc - Issue 10551002: TabContentsWrapper -> TabContents, part 56.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/custom_handlers/protocol_handler_registry_browsertest.cc

Issue 10551002: TabContentsWrapper -> TabContents, part 56. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Not killing GetSelectedWebContents yet Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/automation/automation_provider_observers.h ('k') | chrome/browser/extensions/extension_install_ui_android.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/custom_handlers/protocol_handler_registry_browsertest.cc

diff --git a/chrome/browser/custom_handlers/protocol_handler_registry_browsertest.cc b/chrome/browser/custom_handlers/protocol_handler_registry_browsertest.cc

index ff2e8040ebc0e4ee9a5caca2c84fb097561bf5c8..bd8e6a7bf2a85532751f9b4971e96ea74619a04e 100644

--- a/chrome/browser/custom_handlers/protocol_handler_registry_browsertest.cc

+++ b/chrome/browser/custom_handlers/protocol_handler_registry_browsertest.cc

@@ -51,7 +51,7 @@ class RegisterProtocolHandlerBrowserTest : public InProcessBrowserTest {

params.media_type = WebKit::WebContextMenuData::MediaTypeNone;

params.link_url = url;

params.unfiltered_link_url = url;

- WebContents* web_contents = browser()->GetSelectedWebContents();

+ WebContents* web_contents = browser()->GetActiveWebContents();

params.page_url = web_contents->GetController().GetActiveEntry()->GetURL();

#if defined(OS_MACOSX)

params.writing_direction_default = 0;

@@ -59,7 +59,7 @@ class RegisterProtocolHandlerBrowserTest : public InProcessBrowserTest {

params.writing_direction_right_to_left = 0;

#endif // OS_MACOSX

TestRenderViewContextMenu* menu = new TestRenderViewContextMenu(

- browser()->GetSelectedWebContents(), params);

+ browser()->GetActiveWebContents(), params);

menu->Init();

return menu;

}

@@ -107,5 +107,5 @@ IN_PROC_BROWSER_TEST_F(RegisterProtocolHandlerBrowserTest, CustomHandler) {

ui_test_utils::NavigateToURL(browser(), GURL("foo:test"));

- ASSERT_EQ(handler_url, browser()->GetSelectedWebContents()->GetURL());

+ ASSERT_EQ(handler_url, browser()->GetActiveWebContents()->GetURL());

}