Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Side by Side Diff: test/mjsunit/compare-known-objects-slow.js

Issue 10548046: Fix assertion for map code cache of shared maps. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/objects.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
11 // with the distribution. 11 // with the distribution.
12 // * Neither the name of Google Inc. nor the names of its 12 // * Neither the name of Google Inc. nor the names of its
13 // contributors may be used to endorse or promote products derived 13 // contributors may be used to endorse or promote products derived
14 // from this software without specific prior written permission. 14 // from this software without specific prior written permission.
15 // 15 //
16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS 16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT 17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR 18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT 19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, 20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT 21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
27 27
28 // Flags: --allow-natives-syntax 28 // Flags: --allow-natives-syntax
29 29
30 // Test inlining at call sites with mismatched arity. 30 // Test CompareIC stubs for normal and strict equality comparison of known
31 // objects in slow mode. These objects share the same map even though they
32 // might have completely different properties.
31 33
32 function f(a) { 34 function eq(a, b) {
33 return a.x; 35 return a == b;
34 } 36 }
35 37
36 function g(a, b) { 38 function eq_strict(a, b) {
37 return a.x; 39 return a === b;
38 } 40 }
39 41
40 function h1(a, b) { 42 function test(a, b) {
41 return f(a, a) * g(b); 43 // Check CompareIC for equality of known objects.
44 assertTrue(eq(a, a));
45 assertTrue(eq(b, b));
46 assertFalse(eq(a, b));
47 // Check CompareIC for strict equality of known objects.
48 assertTrue(eq_strict(a, a));
49 assertTrue(eq_strict(b, b));
50 assertFalse(eq_strict(a, b));
42 } 51 }
43 52
44 function h2(a, b) { 53 // Prepare two objects in slow mode that have the same map.
45 return f(a, a) * g(b); 54 var obj1 = %OptimizeObjectForAddingMultipleProperties({}, 1);
46 } 55 var obj2 = %OptimizeObjectForAddingMultipleProperties({}, 1);
47 56
57 // Test original objects.
58 assertTrue(%HaveSameMap(obj1, obj2));
59 test(obj1, obj2);
48 60
49 var o = {x: 2}; 61 // Test after adding property to first object.
62 obj1.x = 1;
63 assertTrue(%HaveSameMap(obj1, obj2));
64 test(obj1, obj2);
50 65
51 assertEquals(4, h1(o, o)); 66 // Test after adding property to second object.
52 assertEquals(4, h1(o, o)); 67 obj2.y = 2;
53 assertEquals(4, h2(o, o)); 68 assertTrue(%HaveSameMap(obj1, obj2));
54 assertEquals(4, h2(o, o)); 69 test(obj1, obj2);
55 %OptimizeFunctionOnNextCall(h1);
56 %OptimizeFunctionOnNextCall(h2);
57 assertEquals(4, h1(o, o));
58 assertEquals(4, h2(o, o));
59
60 var u = {y:0, x:1};
61 assertEquals(2, h1(u, o));
62 assertEquals(2, h2(o, u));
OLDNEW
« no previous file with comments | « src/objects.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698