Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 10548031: [Mac] More descriptive process name for flapper. (Closed)

Created:
8 years, 6 months ago by Scott Hess - ex-Googler
Modified:
8 years, 6 months ago
Reviewers:
stuartmorgan, brettw, jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jochen+watch-content_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

[Mac] More descriptive process name for flapper. Put plugin basename without extension in process name. The human-readable name used for NPAPI version will be a little more complicated to land, so punting for now. BUG=132244 TEST=Activity Monitor app shows "PepperFlashPlayer" under Process Name. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=143659

Patch Set 1 #

Patch Set 2 : Seems reasonable for content/ppapi_plugin to see content/public/plugin #

Patch Set 3 : Only when out-of-process. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M content/app/content_main_runner.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M content/ppapi_plugin/DEPS View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/ppapi_plugin/ppapi_thread.cc View 1 2 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (0 generated)
Scott Hess - ex-Googler
content::PepperPluginInfo is manually created up chrome_content_client.cc, and AFAICT only in the browser. My best guess ...
8 years, 6 months ago (2012-06-13 19:34:37 UTC) #1
stuartmorgan
LGTM as an interim solution
8 years, 6 months ago (2012-06-18 09:38:41 UTC) #2
Scott Hess - ex-Googler
Brett, I think you are the intersection of OWNERS for these files.
8 years, 6 months ago (2012-06-18 16:59:36 UTC) #3
brettw
lgtm
8 years, 6 months ago (2012-06-18 17:03:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/10548031/1
8 years, 6 months ago (2012-06-18 17:04:43 UTC) #5
commit-bot: I haz the power
Presubmit check for 10548031-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 6 months ago (2012-06-18 17:04:46 UTC) #6
Scott Hess - ex-Googler
Darn you noparent! Sorry Brett. jam, need an owners LGTM for the content_main_runner.cc change.
8 years, 6 months ago (2012-06-18 17:29:12 UTC) #7
jam
lgtm the OWNERS in content/app shouldn't have set noparent. i'll fix that.
8 years, 6 months ago (2012-06-18 18:22:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/10548031/1
8 years, 6 months ago (2012-06-18 18:25:49 UTC) #9
commit-bot: I haz the power
Try job failure for 10548031-1 (retry) on linux_rel for steps "browser_tests, check_deps". It's a second ...
8 years, 6 months ago (2012-06-18 19:11:50 UTC) #10
Scott Hess - ex-Googler
Oops, forgot about this one. John, any concerns about the DEPS change? Seems like alright ...
8 years, 6 months ago (2012-06-18 23:37:23 UTC) #11
Scott Hess - ex-Googler
John, WDYT of the DEPS change?
8 years, 6 months ago (2012-06-19 22:00:09 UTC) #12
Scott Hess - ex-Googler
On 2012/06/19 22:00:09, shess wrote: > John, WDYT of the DEPS change? jam, DEPS ping.
8 years, 6 months ago (2012-06-20 22:46:42 UTC) #13
jam
On 2012/06/20 22:46:42, shess wrote: > On 2012/06/19 22:00:09, shess wrote: > > John, WDYT ...
8 years, 6 months ago (2012-06-20 22:48:58 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/10548031/3003
8 years, 6 months ago (2012-06-20 22:52:03 UTC) #15
commit-bot: I haz the power
Try job failure for 10548031-3003 (retry) on linux_rel for step "browser_tests". It's a second try, ...
8 years, 6 months ago (2012-06-20 23:48:31 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/10548031/3003
8 years, 6 months ago (2012-06-21 19:19:33 UTC) #17
commit-bot: I haz the power
Try job failure for 10548031-3003 (retry) on linux_rel for step "browser_tests". It's a second try, ...
8 years, 6 months ago (2012-06-21 20:23:31 UTC) #18
Scott Hess - ex-Googler
Brett, When running in-process, it's not a plugin process, so things aren't setup. So I ...
8 years, 6 months ago (2012-06-22 00:25:59 UTC) #19
brettw
lgtm
8 years, 6 months ago (2012-06-22 17:00:45 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/10548031/35003
8 years, 6 months ago (2012-06-22 17:03:44 UTC) #21
commit-bot: I haz the power
8 years, 6 months ago (2012-06-22 19:02:44 UTC) #22
Change committed as 143659

Powered by Google App Engine
This is Rietveld 408576698