Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: net/socket_stream/socket_stream.cc

Issue 10548028: NetLogEventParameter to Callback refactoring 8. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Fix bad paste Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/base/multi_threaded_cert_verifier.cc ('k') | net/websockets/websocket_job.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket_stream/socket_stream.cc
===================================================================
--- net/socket_stream/socket_stream.cc (revision 142108)
+++ net/socket_stream/socket_stream.cc (working copy)
@@ -113,7 +113,7 @@
pac_request_ = NULL;
}
- net_log_.EndEvent(NetLog::TYPE_REQUEST_ALIVE, NULL);
+ net_log_.EndEvent(NetLog::TYPE_REQUEST_ALIVE);
net_log_ = BoundNetLog();
if (context) {
@@ -121,7 +121,7 @@
context->net_log(),
NetLog::SOURCE_SOCKET_STREAM);
- net_log_.BeginEvent(NetLog::TYPE_REQUEST_ALIVE, NULL);
+ net_log_.BeginEvent(NetLog::TYPE_REQUEST_ALIVE);
}
}
@@ -150,8 +150,7 @@
next_state_ = STATE_BEFORE_CONNECT;
net_log_.BeginEvent(
NetLog::TYPE_SOCKET_STREAM_CONNECT,
- make_scoped_refptr(
- new NetLogStringParameter("url", url_.possibly_invalid_spec())));
+ NetLog::StringCallback("url", &url_.possibly_invalid_spec()));
MessageLoop::current()->PostTask(
FROM_HERE,
base::Bind(&SocketStream::DoLoop, this, OK));
@@ -236,7 +235,7 @@
if (!delegate_)
return;
delegate_ = NULL;
- net_log_.AddEvent(NetLog::TYPE_CANCELLED, NULL);
+ net_log_.AddEvent(NetLog::TYPE_CANCELLED);
// We don't need to send pending data when client detach the delegate.
pending_write_bufs_.clear();
Close();
@@ -329,7 +328,7 @@
next_state_ = STATE_READ_WRITE;
metrics_->OnConnected();
- net_log_.EndEvent(NetLog::TYPE_SOCKET_STREAM_CONNECT, NULL);
+ net_log_.EndEvent(NetLog::TYPE_SOCKET_STREAM_CONNECT);
if (delegate_)
delegate_->OnConnected(this, max_pending_send_allowed_);
@@ -339,7 +338,7 @@
int SocketStream::DidReceiveData(int result) {
DCHECK(read_buf_);
DCHECK_GT(result, 0);
- net_log_.AddEvent(NetLog::TYPE_SOCKET_STREAM_RECEIVED, NULL);
+ net_log_.AddEvent(NetLog::TYPE_SOCKET_STREAM_RECEIVED);
int len = result;
metrics_->OnRead(len);
if (delegate_) {
@@ -352,7 +351,7 @@
int SocketStream::DidSendData(int result) {
DCHECK_GT(result, 0);
- net_log_.AddEvent(NetLog::TYPE_SOCKET_STREAM_SENT, NULL);
+ net_log_.AddEvent(NetLog::TYPE_SOCKET_STREAM_SENT);
int len = result;
metrics_->OnWrite(len);
current_write_buf_ = NULL;
« no previous file with comments | « net/base/multi_threaded_cert_verifier.cc ('k') | net/websockets/websocket_job.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698