Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Unified Diff: net/base/multi_threaded_cert_verifier.cc

Issue 10548028: NetLogEventParameter to Callback refactoring 8. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Fix bad paste Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/base/host_resolver_impl.cc ('k') | net/socket_stream/socket_stream.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/multi_threaded_cert_verifier.cc
===================================================================
--- net/base/multi_threaded_cert_verifier.cc (revision 142108)
+++ net/base/multi_threaded_cert_verifier.cc (working copy)
@@ -92,7 +92,7 @@
: callback_(callback),
verify_result_(verify_result),
net_log_(net_log) {
- net_log_.BeginEvent(NetLog::TYPE_CERT_VERIFIER_REQUEST, NULL);
+ net_log_.BeginEvent(NetLog::TYPE_CERT_VERIFIER_REQUEST);
}
~CertVerifierRequest() {
@@ -102,15 +102,15 @@
void Cancel() {
callback_.Reset();
verify_result_ = NULL;
- net_log_.AddEvent(NetLog::TYPE_CANCELLED, NULL);
- net_log_.EndEvent(NetLog::TYPE_CERT_VERIFIER_REQUEST, NULL);
+ net_log_.AddEvent(NetLog::TYPE_CANCELLED);
+ net_log_.EndEvent(NetLog::TYPE_CERT_VERIFIER_REQUEST);
}
// Copies the contents of |verify_result| to the caller's
// CertVerifyResult and calls the callback.
void Post(const MultiThreadedCertVerifier::CachedResult& verify_result) {
if (!callback_.is_null()) {
- net_log_.EndEvent(NetLog::TYPE_CERT_VERIFIER_REQUEST, NULL);
+ net_log_.EndEvent(NetLog::TYPE_CERT_VERIFIER_REQUEST);
*verify_result_ = verify_result.result;
callback_.Run(verify_result.error);
}
@@ -271,8 +271,8 @@
~CertVerifierJob() {
if (worker_) {
- net_log_.AddEvent(NetLog::TYPE_CANCELLED, NULL);
- net_log_.EndEvent(NetLog::TYPE_CERT_VERIFIER_JOB, NULL);
+ net_log_.AddEvent(NetLog::TYPE_CANCELLED);
+ net_log_.EndEvent(NetLog::TYPE_CERT_VERIFIER_JOB);
worker_->Cancel();
DeleteAllCanceled();
}
@@ -289,7 +289,7 @@
void HandleResult(
const MultiThreadedCertVerifier::CachedResult& verify_result) {
worker_ = NULL;
- net_log_.EndEvent(NetLog::TYPE_CERT_VERIFIER_JOB, NULL);
+ net_log_.EndEvent(NetLog::TYPE_CERT_VERIFIER_JOB);
UMA_HISTOGRAM_CUSTOM_TIMES("Net.CertVerifier_Job_Latency",
base::TimeTicks::Now() - start_time_,
base::TimeDelta::FromMilliseconds(1),
« no previous file with comments | « net/base/host_resolver_impl.cc ('k') | net/socket_stream/socket_stream.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698