Issue 10548021: Add per-script font support for all ISO 15924 scripts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10548021: Add per-script font support for all ISO 15924 scripts. (Closed)

Created:
8 years, 6 months ago by falken

Modified:
8 years, 6 months ago

Reviewers:
jungshik at Google, Matt Perry

CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add per-script font support for all ISO 15924 scripts. Special script codes Zinh, Zxxx, Zzzz, Qaaa-Qabx are excluded. Also, the various Japanese script codes Hira, Kana, and Jpan are excluded in favor of the single code Hrkt; likewise, for Korean, Kore is excluded in favor of Hang. Hrkt and Hang are used just because they currently are already included; this is planned to change in a separate patch <https://chromiumcodereview.appspot.com/10532105>; BUG=2685 TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=142104

Patch Set 1 #

Patch Set 2 : patch for landing #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -13 lines)			Patch
M	chrome/common/extensions/api/experimental_font_settings.json	View	1	1 chunk	+17 lines, -4 lines	0 comments	Download
M	chrome/common/extensions/docs/examples/api/fontSettings.zip	View	1	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/common/extensions/docs/examples/api/fontSettings/popup.js	View	1	1 chunk	+17 lines, -4 lines	0 comments	Download
M	chrome/common/extensions/docs/experimental.fontSettings.html	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/extensions/docs/samples.json	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/pref_names.cc	View	1	1 chunk	+17 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

falken

This adds all ISO script codes as suggested by Jungshik. mpcomplete: Can you please review? ...

8 years, 6 months ago (2012-06-13 04:26:30 UTC) #1

lgtm

Expand Messages | Collapse Messages