Issue 10548015: Reorder functions in AutocompleteActionPredictor so that if A calls B calls C, they're listed A, B,…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10548015: Reorder functions in AutocompleteActionPredictor so that if A calls B calls C, they're listed A, B,… (Closed)

Created:
8 years, 6 months ago by Peter Kasting

Modified:
8 years, 6 months ago

Reviewers:
dominich

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Reorder functions in AutocompleteActionPredictor so that if A calls B calls C, they're listed A, B, C. (The existing order seemed kind of random.) BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=141791

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+136 lines, -136 lines)			Patch
	M	chrome/browser/predictors/autocomplete_action_predictor.h	View		4 chunks	+21 lines, -21 lines	0 comments	Download
	M	chrome/browser/predictors/autocomplete_action_predictor.cc	View		4 chunks	+115 lines, -115 lines	0 comments	Download

Total messages: 3 (0 generated)

Peter Kasting

Let me know if you don't think this improves anything...

8 years, 6 months ago (2012-06-12 23:43:25 UTC) #1

dominich

Thanks, that's a nice cleanup. I'm assuming you didn't change functionality - the parts I ...

8 years, 6 months ago (2012-06-12 23:48:57 UTC) #2

Indeed, no functional change.  Landing.