Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Side by Side Diff: src/debug.cc

Issue 10548004: Fix failing assertion in r11782. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2100 matching lines...) Expand 10 before | Expand all | Expand 10 after
2111 2111
2112 // Ensures the debug information is present for shared. 2112 // Ensures the debug information is present for shared.
2113 bool Debug::EnsureDebugInfo(Handle<SharedFunctionInfo> shared, 2113 bool Debug::EnsureDebugInfo(Handle<SharedFunctionInfo> shared,
2114 Handle<JSFunction> function) { 2114 Handle<JSFunction> function) {
2115 // Return if we already have the debug info for shared. 2115 // Return if we already have the debug info for shared.
2116 if (HasDebugInfo(shared)) { 2116 if (HasDebugInfo(shared)) {
2117 ASSERT(shared->is_compiled()); 2117 ASSERT(shared->is_compiled());
2118 return true; 2118 return true;
2119 } 2119 }
2120 2120
2121 // Make sure we are prepared to handle breakpoints. 2121 // There will be at least one break point when we are done.
2122 ASSERT(has_break_points_); 2122 has_break_points_ = true;
2123 2123
2124 // Ensure function is compiled. Return false if this failed. 2124 // Ensure function is compiled. Return false if this failed.
2125 if (!function.is_null() && 2125 if (!function.is_null() &&
2126 !JSFunction::EnsureCompiled(function, CLEAR_EXCEPTION)) { 2126 !JSFunction::EnsureCompiled(function, CLEAR_EXCEPTION)) {
2127 return false; 2127 return false;
2128 } 2128 }
2129 2129
2130 // Create the debug info object. 2130 // Create the debug info object.
2131 Handle<DebugInfo> debug_info = FACTORY->NewDebugInfo(shared); 2131 Handle<DebugInfo> debug_info = FACTORY->NewDebugInfo(shared);
2132 2132
(...skipping 1537 matching lines...) Expand 10 before | Expand all | Expand 10 after
3670 { 3670 {
3671 Locker locker; 3671 Locker locker;
3672 Isolate::Current()->debugger()->CallMessageDispatchHandler(); 3672 Isolate::Current()->debugger()->CallMessageDispatchHandler();
3673 } 3673 }
3674 } 3674 }
3675 } 3675 }
3676 3676
3677 #endif // ENABLE_DEBUGGER_SUPPORT 3677 #endif // ENABLE_DEBUGGER_SUPPORT
3678 3678
3679 } } // namespace v8::internal 3679 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698