Fix for issue 2351 - checking assignability on top level getters and setters

compiler/javatests/com/google/dart/compiler/resolver/ResolverCompilerTest.java

 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 package com.google.dart.compiler.resolver;
 
-import static com.google.dart.compiler.common.ErrorExpectation.assertErrors;
-import static com.google.dart.compiler.common.ErrorExpectation.errEx;
-
 import com.google.common.base.Joiner;
 import com.google.common.collect.Lists;
 import com.google.common.io.CharStreams;
 import com.google.dart.compiler.CompilerTestCase;
 import com.google.dart.compiler.DartCompilationError;
 import com.google.dart.compiler.Source;
 import com.google.dart.compiler.ast.ASTVisitor;
 import com.google.dart.compiler.ast.DartClass;
 import com.google.dart.compiler.ast.DartDeclaration;
 import com.google.dart.compiler.ast.DartExprStmt;
 import com.google.dart.compiler.ast.DartExpression;
+import com.google.dart.compiler.ast.DartField;
 import com.google.dart.compiler.ast.DartFieldDefinition;
 import com.google.dart.compiler.ast.DartFunctionExpression;
 import com.google.dart.compiler.ast.DartFunctionTypeAlias;
 import com.google.dart.compiler.ast.DartIdentifier;
 import com.google.dart.compiler.ast.DartLabel;
 import com.google.dart.compiler.ast.DartMethodDefinition;
 import com.google.dart.compiler.ast.DartNewExpression;
 import com.google.dart.compiler.ast.DartNode;
 import com.google.dart.compiler.ast.DartParameter;
 import com.google.dart.compiler.ast.DartStatement;
 import com.google.dart.compiler.ast.DartTypeNode;
 import com.google.dart.compiler.ast.DartTypeParameter;
 import com.google.dart.compiler.ast.DartUnit;
 import com.google.dart.compiler.ast.DartVariableStatement;
 import com.google.dart.compiler.common.SourceInfo;
 import com.google.dart.compiler.type.FunctionAliasType;
 import com.google.dart.compiler.type.Type;
 import com.google.dart.compiler.type.TypeVariable;
 
+import static com.google.dart.compiler.common.ErrorExpectation.assertErrors;
+import static com.google.dart.compiler.common.ErrorExpectation.errEx;
+
 import java.io.Reader;
 import java.util.LinkedList;
 import java.util.List;
 
 /**
  * Variant of {@link ResolverTest}, which is based on {@link CompilerTestCase}. It is probably
  * slower, not actually unit test, but easier to use if you need access to DartNode's.
  */
 public class ResolverCompilerTest extends CompilerTestCase {
 
@@ skipping 755 matching lines @@
       {
         DartTypeParameter typeParameter = classA.getTypeParameters().get(0);
         assertDeclarationNameElement(typeParameter, "B");
       }
       {
         DartFieldDefinition fieldDef = (DartFieldDefinition) classA.getMembers().get(0);
         assertDeclarationNameElement(fieldDef.getFields().get(0), "a1");
       }
       {
         DartFieldDefinition fieldDef = (DartFieldDefinition) classA.getMembers().get(1);
-        assertDeclarationNameElement(fieldDef.getFields().get(0), "a2");
+        // since this is a getter, its actually a method element different from the original.
+        DartField f = fieldDef.getFields().get(0);
+        assertNotNull(f);
+        Element e = f.getElement();
+        assertNotNull(e);
+        assertTrue(f.getName().getName().equals("a2"));
+        assertTrue(e.getName().equals("a2"));
       }
       {
         DartMethodDefinition constructor = (DartMethodDefinition) classA.getMembers().get(2);
         assertDeclarationNameElement(constructor, "");
       }
     }
     // top level "c"
     {
       DartFieldDefinition fieldDef = (DartFieldDefinition) unit.getTopLevelNodes().get(1);
       assertDeclarationNameElement(fieldDef.getFields().get(0), "c");
@@ skipping 66 matching lines @@
   /**
    * Asserts that given nodes have same not <code>null</code> {@link Element}.
    */
   private static void assertNameHasSameElement(DartNode node, DartExpression nameNode, String name) {
     Element expectedElement = node.getElement();
     assertNotNull(expectedElement);
     assertEquals(name, expectedElement.getName());
     assertSame(expectedElement, nameNode.getElement());
   }
 }