Fix list traversal of optimized functions in deoptimizer.

Fix list traversal of optimized functions in deoptimizer.

R=fschneider@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=11829

[Michael Starzinger, 2012-06-14 23:10:04]

This fixes the current failures for no-snapshot debug builders on the waterfall.

[Michael Starzinger, 2012-06-14 23:17:46]

Actually this modification is invalid, because there are other visitors that
don't remove the head of the list. I'll fix that tomorrow.

[Michael Starzinger, 2012-06-15 10:31:04]

Now it is flexible enough to deal with all types of visitors. Should have
listened to Sven right away, when he told me to use snapshotting.

[Florian Schneider, 2012-06-15 10:31:47]

LGTM!

https://chromiumcodereview.appspot.com/10546179/diff/4001/src/deoptimizer.cc
File src/deoptimizer.cc (right):

https://chromiumcodereview.appspot.com/10546179/diff/4001/src/deoptimizer.cc#...
src/deoptimizer.cc:279: // Create a snapshot of the optimized functions list.
Maybe add to the comment why this was necessary: Visitors may remove one or more
JSFunctions from the list etc...

[Michael Starzinger, 2012-06-15 10:36:34]

Landing ...

https://chromiumcodereview.appspot.com/10546179/diff/4001/src/deoptimizer.cc
File src/deoptimizer.cc (right):

https://chromiumcodereview.appspot.com/10546179/diff/4001/src/deoptimizer.cc#...
src/deoptimizer.cc:279: // Create a snapshot of the optimized functions list.
On 2012/06/15 10:31:47, Florian Schneider wrote:
> Maybe add to the comment why this was necessary: Visitors may remove one or
more
> JSFunctions from the list etc...

Done.