Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 10546171: Fix packed-element.js test on ARM with no snap (Closed)

Created:
8 years, 6 months ago by danno
Modified:
8 years, 6 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Fix packed-element.js test on ARM with no snap R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=11826

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/arm/macro-assembler-arm.cc View 1 chunk +2 lines, -1 line 2 comments Download

Messages

Total messages: 5 (0 generated)
danno
8 years, 6 months ago (2012-06-14 16:12:57 UTC) #1
Michael Starzinger
That's a classical "how did that even work before" moment. It seems MIPS has the ...
8 years, 6 months ago (2012-06-14 16:44:37 UTC) #2
Michael Starzinger
https://chromiumcodereview.appspot.com/10546171/diff/1/src/arm/macro-assembler-arm.cc File src/arm/macro-assembler-arm.cc (right): https://chromiumcodereview.appspot.com/10546171/diff/1/src/arm/macro-assembler-arm.cc#newcode2888 src/arm/macro-assembler-arm.cc:2888: ldr(map_in_out, FieldMemOperand(scratch, offset)); On 2012/06/14 16:44:37, Michael Starzinger wrote: ...
8 years, 6 months ago (2012-06-14 19:51:01 UTC) #3
danno
I don't want to do the MIPS port, since I'm not sure what the equivalent ...
8 years, 6 months ago (2012-06-15 08:52:35 UTC) #4
Michael Starzinger
8 years, 6 months ago (2012-06-15 09:11:52 UTC) #5
LGTM. We just need to make sure this doesn't slip through the cracks.

Powered by Google App Engine
This is Rietveld 408576698