compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerTest.java - Issue 10546168: Issue 3540. Better error message for string concatenation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerTest.java

Issue 10546168: Issue 3540. Better error message for string concatenation (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« compiler/java/com/google/dart/compiler/ast/DartBinaryExpression.java ('K') | « compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerTest.java

diff --git a/compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerTest.java b/compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerTest.java

index 76b45e1f6d4dc9e01cdcde0a70dbb0279a50f92f..8a509faf5ff0b40beb4a66f413dc019a862b21d0 100644

--- a/compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerTest.java

+++ b/compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerTest.java

@@ -1388,12 +1388,8 @@ public class TypeAnalyzerTest extends TypeAnalyzerTestCase {

analyze("{ var c = a + b; }");

analyzeFail("{ var c = s + b; }",

TypeErrorCode.PLUS_CANNOT_BE_USED_FOR_STRING_CONCAT);

- analyzeFail("{ var c = a + s; }",

- TypeErrorCode.PLUS_CANNOT_BE_USED_FOR_STRING_CONCAT);

analyzeFail("var c = 'foo' + 1;",

TypeErrorCode.PLUS_CANNOT_BE_USED_FOR_STRING_CONCAT);

- analyzeFail("var c = 1 + 'foo';",

- TypeErrorCode.PLUS_CANNOT_BE_USED_FOR_STRING_CONCAT);

analyzeFail("var c = 'foo' + 'bar';",

TypeErrorCode.PLUS_CANNOT_BE_USED_FOR_STRING_CONCAT);

}