Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Unified Diff: webkit/dom_storage/dom_storage_session.h

Issue 10546167: Create and store persistent unique ids for sessionStorage. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: code review Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/dom_storage/dom_storage_namespace.cc ('k') | webkit/dom_storage/dom_storage_session.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/dom_storage/dom_storage_session.h
diff --git a/webkit/dom_storage/dom_storage_session.h b/webkit/dom_storage/dom_storage_session.h
index c1add408e883ef23cfa07e9b11d11443f913a52b..6de9f953882ac720779c969cb5f44081b72b4c7b 100644
--- a/webkit/dom_storage/dom_storage_session.h
+++ b/webkit/dom_storage/dom_storage_session.h
@@ -6,6 +6,8 @@
#define WEBKIT_DOM_STORAGE_DOM_STORAGE_SESSION_H_
#pragma once
+#include <string>
+
#include "base/basictypes.h"
#include "base/memory/ref_counted.h"
@@ -20,21 +22,36 @@ class DomStorageContext;
class DomStorageSession
: public base::RefCountedThreadSafe<DomStorageSession> {
public:
+ // Constructs a |DomStorageSession| and allocates new IDs for it.
explicit DomStorageSession(DomStorageContext* context);
+
+ // Constructs a |DomStorageSession| and assigns |persistent_namespace_id|
+ // to it. Allocates a new non-persistent ID.
+ DomStorageSession(DomStorageContext* context,
+ const std::string& persistent_namespace_id);
+
int64 namespace_id() const { return namespace_id_; }
+ const std::string& persistent_namespace_id() const {
+ return persistent_namespace_id_;
+ }
DomStorageSession* Clone();
+ // Constructs a |DomStorageSession| by cloning
+ // |namespace_id_to_clone|. Allocates new IDs for it.
static DomStorageSession* CloneFrom(DomStorageContext* context,
int64 namepace_id_to_clone);
private:
friend class base::RefCountedThreadSafe<DomStorageSession>;
- DomStorageSession(DomStorageContext* context, int64 namespace_id);
+ DomStorageSession(DomStorageContext* context,
+ int64 namespace_id,
+ const std::string& persistent_namespace_id);
~DomStorageSession();
scoped_refptr<DomStorageContext> context_;
int64 namespace_id_;
+ std::string persistent_namespace_id_;
DISALLOW_IMPLICIT_CONSTRUCTORS(DomStorageSession);
};
« no previous file with comments | « webkit/dom_storage/dom_storage_namespace.cc ('k') | webkit/dom_storage/dom_storage_session.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698