Issue 10546166: ES5.2 var semantics: take hidden prototypes into account.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10546166: ES5.2 var semantics: take hidden prototypes into account. (Closed)

Created:
8 years, 6 months ago by rossberg

Modified:
8 years, 6 months ago

Reviewers:
arv (Not doing code reviews), Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

ES5.2 var semantics: take hidden prototypes into account. R=mstarzinger@chromium.org BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=11818

Patch Set 1 #

Total comments: 2

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -4 lines)			Patch
	M	src/runtime.cc	View		1 chunk	+10 lines, -4 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM (with one nit). Also do we have test coverage for that, once es52_globals is ...

8 years, 6 months ago (2012-06-14 13:16:28 UTC) #2

arv (Not doing code reviews)

8 years, 6 months ago (2012-06-20 19:34:14 UTC) #3

FYI

https://chromiumcodereview.appspot.com/10546166/diff/1/src/runtime.cc
File src/runtime.cc (right):

https://chromiumcodereview.appspot.com/10546166/diff/1/src/runtime.cc#newcode...
src/runtime.cc:1319: } while (!lookup.IsFound() && obj->IsJSObject() &&
On 2012/06/14 13:16:28, Michael Starzinger wrote:
> Can we move the "lookup.IsFound()" condition into the loop before getting the
> prototype? That would be cleaner IMHO ...
> 
> if (lookup.isFound()) break;

Also, there is no reason to get the prototype if lookup.IsFound() is true.

Maybe the compiler is smart enough to realize that but why take that risk?

Expand Messages | Collapse Messages