Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Side by Side Diff: chrome/browser/ui/webui/bidi_checker_web_ui_test.h

Issue 10546139: Do the ReloadLocaleResources() call on the IO thread to avoid synchronization issues. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove ui_test_utils:: for call within same namespace. Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_WEBUI_BIDI_CHECKER_WEB_UI_TEST_H_ 5 #ifndef CHROME_BROWSER_UI_WEBUI_BIDI_CHECKER_WEB_UI_TEST_H_
6 #define CHROME_BROWSER_UI_WEBUI_BIDI_CHECKER_WEB_UI_TEST_H_ 6 #define CHROME_BROWSER_UI_WEBUI_BIDI_CHECKER_WEB_UI_TEST_H_
7 #pragma once 7 #pragma once
8 8
9 #include <string> 9 #include <string>
10 10
11 #include "chrome/browser/ui/webui/web_ui_browsertest.h" 11 #include "chrome/browser/ui/webui/web_ui_browsertest.h"
12 #include "chrome/test/base/in_process_browser_test.h" 12 #include "chrome/test/base/in_process_browser_test.h"
13 13
14 namespace base {
15 class WaitableEvent;
16 }
17
14 // Base class for BidiChecker-based tests. Preloads the BidiChecker JS library 18 // Base class for BidiChecker-based tests. Preloads the BidiChecker JS library
15 // for each test. 19 // for each test.
16 class WebUIBidiCheckerBrowserTest : public WebUIBrowserTest { 20 class WebUIBidiCheckerBrowserTest : public WebUIBrowserTest {
17 public: 21 public:
18 virtual ~WebUIBidiCheckerBrowserTest(); 22 virtual ~WebUIBidiCheckerBrowserTest();
19 23
20 protected: 24 protected:
21 WebUIBidiCheckerBrowserTest(); 25 WebUIBidiCheckerBrowserTest();
22 26
23 // Runs the Bidi Checker on the given page URL. |is_rtl| should be true when 27 // Runs the Bidi Checker on the given page URL. |is_rtl| should be true when
(...skipping 12 matching lines...) Expand all
36 40
37 // Base class for BidiChecker-based tests that run with an RTL UI. 41 // Base class for BidiChecker-based tests that run with an RTL UI.
38 class WebUIBidiCheckerBrowserTestRTL : public WebUIBidiCheckerBrowserTest { 42 class WebUIBidiCheckerBrowserTestRTL : public WebUIBidiCheckerBrowserTest {
39 public: 43 public:
40 void RunBidiCheckerOnPage(const std::string& page_url); 44 void RunBidiCheckerOnPage(const std::string& page_url);
41 45
42 protected: 46 protected:
43 virtual void SetUpOnMainThread() OVERRIDE; 47 virtual void SetUpOnMainThread() OVERRIDE;
44 virtual void CleanUpOnMainThread() OVERRIDE; 48 virtual void CleanUpOnMainThread() OVERRIDE;
45 49
50 static void SetUpOnIOThread(base::WaitableEvent* event);
51
46 // The app locale before we change it 52 // The app locale before we change it
47 std::string app_locale_; 53 std::string app_locale_;
48 }; 54 };
49 55
50 #endif // CHROME_BROWSER_UI_WEBUI_BIDI_CHECKER_WEB_UI_TEST_H_ 56 #endif // CHROME_BROWSER_UI_WEBUI_BIDI_CHECKER_WEB_UI_TEST_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698