Issue 10546128: Reland after revert - Adds parsing for the app_id field from an

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10546128: Reland after revert - Adds parsing for the app_id field from an (Closed)

Created:
8 years, 6 months ago by Greg Spencer (Chromium)

Modified:
8 years, 6 months ago

Reviewers:
zel

CC:
chromium-reviews, achuith+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Reland after revert - Adds parsing for the app_id field from an "open-with-" link in Drive. Later CLs will use app_id field to look up an associated app. Also adjusted unit test so that it would assert less and expect more. I expect more from my unit tests. :-) Original review: http://codereview.chromium.org/10546034/ TBR=zelidrag@chromium.org BUG=chromium:126895 TEST=Ran updated unit test. Ran clang trybot. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=141696

Patch Set 1 #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+262 lines, -127 lines)			Patch
M	chrome/browser/chromeos/gdata/gdata_parser.h	View	2 chunks	+17 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_parser.cc	View	3 chunks	+52 lines, -6 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_parser_unittest.cc	View	8 chunks	+183 lines, -115 lines	0 comments	Download
M	chrome/test/data/chromeos/gdata/basic_feed.json	View	2 chunks	+9 lines, -1 line	0 comments	Download
M	chrome/test/data/chromeos/gdata/entry.xml	View	1 chunk	+1 line, -1 line	0 comments	Download