Issue 3534. It is a compile-time error if a typedef refers to itself

Issue 3534. It is a compile-time error if a typedef refers to itself
http://code.google.com/p/dart/issues/detail?id=3534


R=brianwilkerson@google.com
BUG=
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=8561

[Brian Wilkerson, 2012-06-12 15:54:37]

https://chromiumcodereview.appspot.com/10546118/diff/1/compiler/java/com/goog...
File compiler/java/com/google/dart/compiler/resolver/TypeErrorCode.java (right):

https://chromiumcodereview.appspot.com/10546118/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/resolver/TypeErrorCode.java:61:
TYPE_ALIAS_CANNOT_REFERENCES_ITSELF(ErrorSeverity.ERROR, "Type alias cannot
reference itself directly of via other typedefs"),
nit: "REFERENCES" --> "REFERENCE"

https://chromiumcodereview.appspot.com/10546118/diff/1/compiler/java/com/goog...
File compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java (right):

https://chromiumcodereview.appspot.com/10546118/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java:1404:
FunctionAliasType type = element.getType();
nit: this could move to before the "if"

https://chromiumcodereview.appspot.com/10546118/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java:2284:
visited.clear();
There is no reason to clear the set here because it was just created, and I
don't think that there's any reason to clear it in the other places either. If
we have something like

  typedef F<E>(E x);

Once we've checked that 'E' doesn't reference 'F' as part of checking the type
parameters, there's no need to check again when checking the parameter types.

Speaking of which, this code does not yet check the type parameters.

https://chromiumcodereview.appspot.com/10546118/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java:2336: // normal
parameters
Also not checking type parameters.

[scheglov, 2012-06-12 16:45:41]

https://chromiumcodereview.appspot.com/10546118/diff/1/compiler/java/com/goog...
File compiler/java/com/google/dart/compiler/resolver/TypeErrorCode.java (right):

https://chromiumcodereview.appspot.com/10546118/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/resolver/TypeErrorCode.java:61:
TYPE_ALIAS_CANNOT_REFERENCES_ITSELF(ErrorSeverity.ERROR, "Type alias cannot
reference itself directly of via other typedefs"),
On 2012/06/12 15:54:37, Brian Wilkerson wrote:
> nit: "REFERENCES" --> "REFERENCE"

Done.

https://chromiumcodereview.appspot.com/10546118/diff/1/compiler/java/com/goog...
File compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java (right):

https://chromiumcodereview.appspot.com/10546118/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java:1404:
FunctionAliasType type = element.getType();
On 2012/06/12 15:54:37, Brian Wilkerson wrote:
> nit: this could move to before the "if"

Done.

https://chromiumcodereview.appspot.com/10546118/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java:2284:
visited.clear();
On 2012/06/12 15:54:37, Brian Wilkerson wrote:
> There is no reason to clear the set here because it was just created, and I
> don't think that there's any reason to clear it in the other places either. If
> we have something like
> 
>   typedef F<E>(E x);
> 
> Once we've checked that 'E' doesn't reference 'F' as part of checking the type
> parameters, there's no need to check again when checking the parameter types.
> 
> Speaking of which, this code does not yet check the type parameters.

Done.

https://chromiumcodereview.appspot.com/10546118/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java:2336: // normal
parameters
On 2012/06/12 15:54:37, Brian Wilkerson wrote:
> Also not checking type parameters.

co19 does not agree that we should check type parameters.
Here under "type parameters" I understand "bounds of type parameters".
This is positive test in co19.

[Brian Wilkerson, 2012-06-12 17:25:02]

LGTM

https://chromiumcodereview.appspot.com/10546118/diff/1/compiler/java/com/goog...
File compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java (right):

https://chromiumcodereview.appspot.com/10546118/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java:2336: // normal
parameters
OK. The spec doesn't explicitly mention type parameter bounds, but what it does
say seems rather inclusive. Given that the co19 tests are not perfect, a quick
e-mail to Gilad might be in order.