Issue 10546117: Browser Plugin: Make basic focus in guests work

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10546117: Browser Plugin: Make basic focus in guests work (Closed)

Created:
8 years, 6 months ago by Fady Samuel

Modified:
8 years, 6 months ago

Reviewers:
jam

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch-content_chromium.org

Base URL:
http://git.chromium.org/git/chromium.git@trunk

Visibility:
Public.

Browser Plugin: Make basic focus in guests work BUG=120263 TEST=manually Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141625

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	content/renderer/browser_plugin/guest_to_embedder_channel.cc	View	1	1 chunk	+5 lines, -1 line	0 comments	Download

Total messages: 6 (0 generated)

Fady Samuel

Hi John, Could you please review this small patch to make focus work in guests. ...

8 years, 6 months ago (2012-06-12 01:00:51 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/10546117/1

8 years, 6 months ago (2012-06-12 01:17:48 UTC) #3

commit-bot: I haz the power

Try job failure for 10546117-1 (retry) on win_rel for step "compile" (clobber build). It's a ...

8 years, 6 months ago (2012-06-12 02:40:04 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/10546117/4

8 years, 6 months ago (2012-06-12 03:56:10 UTC) #5

Change committed as 141625