Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Side by Side Diff: platform/thread_macos.cc

Issue 10546112: Set thread stack size to 128k on macos debug builds as the parser runs into a stack overflow error … (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "platform/thread.h" 5 #include "platform/thread.h"
6 6
7 #include <sys/errno.h> 7 #include <sys/errno.h>
8 8
9 #include "platform/assert.h" 9 #include "platform/assert.h"
10 10
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
64 64
65 65
66 int Thread::Start(ThreadStartFunction function, uword parameter) { 66 int Thread::Start(ThreadStartFunction function, uword parameter) {
67 pthread_attr_t attr; 67 pthread_attr_t attr;
68 int result = pthread_attr_init(&attr); 68 int result = pthread_attr_init(&attr);
69 RETURN_ON_PTHREAD_FAILURE(result); 69 RETURN_ON_PTHREAD_FAILURE(result);
70 70
71 result = pthread_attr_setdetachstate(&attr, PTHREAD_CREATE_DETACHED); 71 result = pthread_attr_setdetachstate(&attr, PTHREAD_CREATE_DETACHED);
72 RETURN_ON_PTHREAD_FAILURE(result); 72 RETURN_ON_PTHREAD_FAILURE(result);
73 73
74 #if DEBUG
75 const int kStackSize = (128 * KB);
76 #else
74 const int kStackSize = (64 * KB); 77 const int kStackSize = (64 * KB);
78 #endif
75 result = pthread_attr_setstacksize(&attr, kStackSize); 79 result = pthread_attr_setstacksize(&attr, kStackSize);
76 RETURN_ON_PTHREAD_FAILURE(result); 80 RETURN_ON_PTHREAD_FAILURE(result);
77 81
78 ThreadStartData* data = new ThreadStartData(function, parameter); 82 ThreadStartData* data = new ThreadStartData(function, parameter);
79 83
80 pthread_t tid; 84 pthread_t tid;
81 result = pthread_create(&tid, &attr, ThreadStart, data); 85 result = pthread_create(&tid, &attr, ThreadStart, data);
82 RETURN_ON_PTHREAD_FAILURE(result); 86 RETURN_ON_PTHREAD_FAILURE(result);
83 87
84 result = pthread_attr_destroy(&attr); 88 result = pthread_attr_destroy(&attr);
(...skipping 161 matching lines...) Expand 10 before | Expand all | Expand 10 after
246 } 250 }
247 251
248 252
249 void Monitor::NotifyAll() { 253 void Monitor::NotifyAll() {
250 // TODO(iposva): Do we need to track lock owners? 254 // TODO(iposva): Do we need to track lock owners?
251 int result = pthread_cond_broadcast(data_.cond()); 255 int result = pthread_cond_broadcast(data_.cond());
252 VALIDATE_PTHREAD_RESULT(result); 256 VALIDATE_PTHREAD_RESULT(result);
253 } 257 }
254 258
255 } // namespace dart 259 } // namespace dart
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698