ui/views/controls/menu/menu_delegate.h - Issue 10546104: Make IsTriggerableEvent take Event objects and use it to verify whether tap events should trigger.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/menu/menu_delegate.h

Issue 10546104: Make IsTriggerableEvent take Event objects and use it to verify whether tap events should trigger. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Pass Event to ShouldEnterPushedState. Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/views/controls/menu/menu_delegate.h

diff --git a/ui/views/controls/menu/menu_delegate.h b/ui/views/controls/menu/menu_delegate.h

index a740a431640f640c1b182fd32f4fd8d3c86baa61..b3299469b5b26d95661f35600bd0579bbc209bda 100644

--- a/ui/views/controls/menu/menu_delegate.h

+++ b/ui/views/controls/menu/menu_delegate.h

@@ -114,9 +114,9 @@ class VIEWS_EXPORT MenuDelegate {

// other than a mouse event.

virtual void ExecuteCommand(int id, int mouse_event_flags);

- // Returns true if the specified mouse event is one the user can use

- // to trigger, or accept, the mouse. Defaults to left or right mouse buttons.

- virtual bool IsTriggerableEvent(MenuItemView* view, const MouseEvent& e);

+ // Returns true if the specified event is one the user can use to trigger, or

+ // accept, the item. Defaults to left or right mouse buttons or tap.

+ virtual bool IsTriggerableEvent(MenuItemView* view, const Event& e);

// Invoked to determine if drops can be accepted for a submenu. This is

// ONLY invoked for menus that have submenus and indicates whether or not

« no previous file with comments | « ui/views/controls/button/custom_button.cc ('k') | ui/views/controls/menu/menu_delegate.cc » ('j') | no next file with comments »