Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(843)

Side by Side Diff: src/assembler.h

Issue 10546095: AssemblerBase does not need remember a Zone. Fix this. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/assembler-arm.cc ('k') | src/assembler.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 1994-2006 Sun Microsystems Inc. 1 // Copyright (c) 1994-2006 Sun Microsystems Inc.
2 // All Rights Reserved. 2 // All Rights Reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions are 5 // modification, are permitted provided that the following conditions are
6 // met: 6 // met:
7 // 7 //
8 // - Redistributions of source code must retain the above copyright notice, 8 // - Redistributions of source code must retain the above copyright notice,
9 // this list of conditions and the following disclaimer. 9 // this list of conditions and the following disclaimer.
10 // 10 //
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
50 50
51 namespace internal { 51 namespace internal {
52 52
53 struct StatsCounter; 53 struct StatsCounter;
54 const unsigned kNoASTId = -1; 54 const unsigned kNoASTId = -1;
55 // ----------------------------------------------------------------------------- 55 // -----------------------------------------------------------------------------
56 // Platform independent assembler base class. 56 // Platform independent assembler base class.
57 57
58 class AssemblerBase: public Malloced { 58 class AssemblerBase: public Malloced {
59 public: 59 public:
60 AssemblerBase(Isolate* isolate, Zone* zone); 60 explicit AssemblerBase(Isolate* isolate);
61 61
62 Isolate* isolate() const { return isolate_; } 62 Isolate* isolate() const { return isolate_; }
63 int jit_cookie() { return jit_cookie_; } 63 int jit_cookie() { return jit_cookie_; }
64 64
65 // Overwrite a host NaN with a quiet target NaN. Used by mksnapshot for 65 // Overwrite a host NaN with a quiet target NaN. Used by mksnapshot for
66 // cross-snapshotting. 66 // cross-snapshotting.
67 static void QuietNaN(HeapObject* nan) { } 67 static void QuietNaN(HeapObject* nan) { }
68 68
69 Zone* zone() const { return zone_; }
70
71 private: 69 private:
72 Isolate* isolate_; 70 Isolate* isolate_;
73 int jit_cookie_; 71 int jit_cookie_;
74 Zone* zone_;
75 }; 72 };
76 73
77 74
78 // ----------------------------------------------------------------------------- 75 // -----------------------------------------------------------------------------
79 // Labels represent pc locations; they are typically jump or call targets. 76 // Labels represent pc locations; they are typically jump or call targets.
80 // After declaration, a label can be freely used to denote known or (yet) 77 // After declaration, a label can be freely used to denote known or (yet)
81 // unknown pc location. Assembler::bind() is used to bind a label to the 78 // unknown pc location. Assembler::bind() is used to bind a label to the
82 // current pc. A label can be bound only once. 79 // current pc. A label can be bound only once.
83 80
84 class Label BASE_EMBEDDED { 81 class Label BASE_EMBEDDED {
(...skipping 799 matching lines...) Expand 10 before | Expand all | Expand 10 after
884 public: 881 public:
885 NullCallWrapper() { } 882 NullCallWrapper() { }
886 virtual ~NullCallWrapper() { } 883 virtual ~NullCallWrapper() { }
887 virtual void BeforeCall(int call_size) const { } 884 virtual void BeforeCall(int call_size) const { }
888 virtual void AfterCall() const { } 885 virtual void AfterCall() const { }
889 }; 886 };
890 887
891 } } // namespace v8::internal 888 } } // namespace v8::internal
892 889
893 #endif // V8_ASSEMBLER_H_ 890 #endif // V8_ASSEMBLER_H_
OLDNEW
« no previous file with comments | « src/arm/assembler-arm.cc ('k') | src/assembler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698