Convert ProtocolHandlerRegistry to be a ProfileKeyedService.

chrome/browser/custom_handlers/protocol_handler_registry_factory.cc

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/custom_handlers/protocol_handler_registry_factory.h"
+
+#include "base/memory/singleton.h"
+#include "chrome/browser/custom_handlers/protocol_handler_registry.h"
+#include "chrome/browser/extensions/extension_system_factory.h"
+#include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/profiles/profile_dependency_manager.h"
+
+// static
+ProtocolHandlerRegistryFactory* ProtocolHandlerRegistryFactory::GetInstance() {
+  return Singleton<ProtocolHandlerRegistryFactory>::get();
+}
+
+// static
+ProtocolHandlerRegistry* ProtocolHandlerRegistryFactory::GetForProfile(
+    Profile* profile) {
+

[Peter Kasting, 2012/06/11 00:41:26]

Nit: Extra blank lines (3 places)

[Steve McKay, 2012/06/11 22:09:38]

Done. Though allow me to proselytize for more whitespace a bit. An empty line
after a line wrap makes it easier to distinguish content from the wrapped
content preceding it, especially so in the middle of a block.

[Peter Kasting, 2012/06/12 00:31:37]

I don't mind whitespace in general, but a blank line at the beginning of a
function is something I've never seen elsewhere in Chrome code.

[Steve McKay, 2012/06/14 22:06:23]

Done.

+  return static_cast<ProtocolHandlerRegistry*>(
+      GetInstance()->GetServiceForProfile(profile, true));
+}
+
+ProtocolHandlerRegistryFactory::ProtocolHandlerRegistryFactory()
+    : ProfileKeyedServiceFactory("ProtocolHandlerRegistry",
+                                 ProfileDependencyManager::GetInstance()) {
+
+  // DependsOn(WebIntentsRegistryFactory::GetInstance());

[Elliot Glaysher, 2012/06/11 19:43:16]

Is this supposed to be uncommented? I see that WebIntentsRegistryFactory exists.

[Steve McKay, 2012/06/11 22:09:38]

Trying to segregate CLs to keep the switch to PKS separate from integration with
WebIntentsRegistry. I can remove if this is offensive, but otherwise like it
here for later uncommenting.

[Peter Kasting, 2012/06/12 00:31:37]

Do you mean that right now the ProtocolHandlerRegistry doesn't actually depend
on the WebIntentsRegistry at all?  If so this line should probably be entirely
absent.

[Steve McKay, 2012/06/14 22:06:23]

Done.

+}
+
+ProtocolHandlerRegistryFactory::~ProtocolHandlerRegistryFactory() {
+}
+
+ProfileKeyedService* ProtocolHandlerRegistryFactory::BuildServiceInstanceFor(
+    Profile* profile) const {
+
+  ProtocolHandlerRegistry* registry = new ProtocolHandlerRegistry(
+      profile,
+      new ProtocolHandlerRegistry::Delegate());

[Peter Kasting, 2012/06/11 00:41:26]

Nit: Could put on previous line

[Steve McKay, 2012/06/11 22:09:38]

Done.

+
+  registry->InitProtocolSettings();
+
+  return registry;
+}
+
+bool ProtocolHandlerRegistryFactory::ServiceRedirectedInIncognito() {
+  return false;

[Peter Kasting, 2012/06/11 00:41:26]

This is already the default behavior.

[Steve McKay, 2012/06/11 22:09:38]

Done.

+}