Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(871)

Unified Diff: chrome/browser/ui/toolbar/wrench_menu_model.cc

Issue 10546072: Use different help URLs for menus, accelerators, and WebUI. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: merge Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/gtk/menu_gtk.cc ('k') | chrome/browser/ui/views/accelerator_table.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/toolbar/wrench_menu_model.cc
diff --git a/chrome/browser/ui/toolbar/wrench_menu_model.cc b/chrome/browser/ui/toolbar/wrench_menu_model.cc
index ff52a4a62afbc1643fcf1b8bf20853daccec042e..a06a7b30fcdc102f77d1cde069d84c405d875b5a 100644
--- a/chrome/browser/ui/toolbar/wrench_menu_model.cc
+++ b/chrome/browser/ui/toolbar/wrench_menu_model.cc
@@ -333,7 +333,7 @@ void WrenchMenuModel::ExecuteCommand(int command_id) {
}
}
- if (command_id == IDC_HELP_PAGE)
+ if (command_id == IDC_HELP_PAGE_VIA_MENU)
content::RecordAction(UserMetricsAction("ShowHelpTabViaWrenchMenu"));
browser_->ExecuteCommand(command_id);
@@ -504,11 +504,11 @@ void WrenchMenuModel::Build() {
#endif
if (!is_touch_menu) {
- AddItemWithStringId(IDC_HELP_PAGE, IDS_HELP_PAGE);
+ AddItemWithStringId(IDC_HELP_PAGE_VIA_MENU, IDS_HELP_PAGE);
if (browser_defaults::kShowHelpMenuItemIcon) {
ui::ResourceBundle& rb = ResourceBundle::GetSharedInstance();
- SetIcon(GetIndexOfCommandId(IDC_HELP_PAGE),
+ SetIcon(GetIndexOfCommandId(IDC_HELP_PAGE_VIA_MENU),
*rb.GetImageSkiaNamed(IDR_HELP_MENU));
}
}
« no previous file with comments | « chrome/browser/ui/gtk/menu_gtk.cc ('k') | chrome/browser/ui/views/accelerator_table.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698