Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5234)

Unified Diff: chrome/browser/ui/browser.h

Issue 10546072: Use different help URLs for menus, accelerators, and WebUI. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: merge Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/system/ash_system_tray_delegate.cc ('k') | chrome/browser/ui/browser.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser.h
diff --git a/chrome/browser/ui/browser.h b/chrome/browser/ui/browser.h
index 7cba33948120101ee8a435f2425c0cdecfed3dfb..99c8f52fe68342d25f6ef5c2dd256e434d4b1739 100644
--- a/chrome/browser/ui/browser.h
+++ b/chrome/browser/ui/browser.h
@@ -158,6 +158,18 @@ class Browser : public TabStripModelDelegate,
DOWNLOAD_CLOSE_LAST_WINDOW_IN_INCOGNITO_PROFILE,
};
+ // Sources of requests to show the help tab.
+ enum HelpSource {
+ // Keyboard accelerators.
+ HELP_SOURCE_KEYBOARD,
+
+ // Menus (e.g. wrench menu or Chrome OS system menu).
+ HELP_SOURCE_MENU,
+
+ // WebUI (the "About" page).
+ HELP_SOURCE_WEBUI,
+ };
+
// Different types of action when web app info is available.
// OnDidGetApplicationInfo uses this to dispatch calls.
enum WebAppAction {
@@ -314,7 +326,7 @@ class Browser : public TabStripModelDelegate,
static void OpenAboutWindow(Profile* profile);
static void OpenHistoryWindow(Profile* profile);
static void OpenDownloadsWindow(Profile* profile);
- static void OpenHelpWindow(Profile* profile);
+ static void OpenHelpWindow(Profile* profile, HelpSource source);
static void OpenOptionsWindow(Profile* profile);
static void OpenSyncSetupWindow(Profile* profile,
SyncPromoUI::Source source);
@@ -627,7 +639,7 @@ class Browser : public TabStripModelDelegate,
void OpenInstantConfirmDialog();
void OpenAboutChromeDialog();
void OpenUpdateChromeDialog();
- void ShowHelpTab();
+ void ShowHelpTab(HelpSource source);
void OpenPrivacyDashboardTabAndActivate();
void OpenSearchEngineOptionsDialog();
void OpenPluginsTabAndActivate();
« no previous file with comments | « chrome/browser/chromeos/system/ash_system_tray_delegate.cc ('k') | chrome/browser/ui/browser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698