Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Unified Diff: chrome/browser/ui/views/frame/browser_view.cc

Issue 10546072: Use different help URLs for menus, accelerators, and WebUI. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: ugh core file Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/frame/browser_view.cc
diff --git a/chrome/browser/ui/views/frame/browser_view.cc b/chrome/browser/ui/views/frame/browser_view.cc
index c3a7a1083fcc362051d451f9431fef784bff26a6..fcc15ffe81bb4835d57d1358e27091d4d0a014a9 100644
--- a/chrome/browser/ui/views/frame/browser_view.cc
+++ b/chrome/browser/ui/views/frame/browser_view.cc
@@ -2196,7 +2196,7 @@ int BrowserView::GetCommandIDForAppCommandID(int app_command_id) const {
case APPCOMMAND_BROWSER_HOME: return IDC_HOME;
case APPCOMMAND_BROWSER_STOP: return IDC_STOP;
case APPCOMMAND_BROWSER_SEARCH: return IDC_FOCUS_SEARCH;
- case APPCOMMAND_HELP: return IDC_HELP_PAGE;
+ case APPCOMMAND_HELP: return IDC_HELP_PAGE_VIA_KEYBOARD;
Daniel Erat 2012/06/08 16:28:52 It's unclear to me from http://technet.microsoft.c
case APPCOMMAND_NEW: return IDC_NEW_TAB;
case APPCOMMAND_OPEN: return IDC_OPEN_FILE;
case APPCOMMAND_CLOSE: return IDC_CLOSE_TAB;
@@ -2246,7 +2246,7 @@ void BrowserView::InitHangMonitor() {
void BrowserView::UpdateAcceleratorMetrics(
const ui::Accelerator& accelerator, int command_id) {
const ui::KeyboardCode key_code = accelerator.key_code();
- if (command_id == IDC_HELP_PAGE && key_code == ui::VKEY_F1)
+ if (command_id == IDC_HELP_PAGE_VIA_KEYBOARD && key_code == ui::VKEY_F1)
content::RecordAction(UserMetricsAction("ShowHelpTabViaF1"));
#if defined(OS_CHROMEOS)

Powered by Google App Engine
This is Rietveld 408576698