Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/app_controller_mac.mm

Issue 10546072: Use different help URLs for menus, accelerators, and WebUI. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: ugh core file Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/app/chrome_command_ids.h ('K') | « chrome/app/chrome_dll.rc ('k') | chrome/browser/chromeos/system/ash_system_tray_delegate.cc » ('j') | chrome/browser/ui/views/frame/browser_view.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/app_controller_mac.mm
diff --git a/chrome/browser/app_controller_mac.mm b/chrome/browser/app_controller_mac.mm
index 084113688bb2dcd0271b73d44170c9a9a659e676..a9b15dc5691a5727dc69b1a5ea592d69e716fe91 100644
--- a/chrome/browser/app_controller_mac.mm
+++ b/chrome/browser/app_controller_mac.mm
@@ -891,12 +891,17 @@ const AEEventClass kAECloudPrintUninstallClass = 'GCPu';
else
Browser::OpenExtensionsWindow(lastProfile);
break;
- case IDC_HELP_PAGE:
+ case IDC_HELP_PAGE_VIA_KEYBOARD:
+ case IDC_HELP_PAGE_VIA_MENU: {
+ Browser::HelpSource source = (tag == IDC_HELP_PAGE_VIA_KEYBOARD) ?
+ Browser::HELP_SOURCE_KEYBOARD :
+ Browser::HELP_SOURCE_MENU;
if (Browser* browser = ActivateBrowser(lastProfile))
- browser->ShowHelpTab();
+ browser->ShowHelpTab(source);
else
- Browser::OpenHelpWindow(lastProfile);
+ Browser::OpenHelpWindow(lastProfile, source);
break;
+ }
case IDC_SHOW_SYNC_SETUP:
if (Browser* browser = ActivateBrowser(lastProfile))
browser->ShowSyncSetup(SyncPromoUI::SOURCE_MENU);
« chrome/app/chrome_command_ids.h ('K') | « chrome/app/chrome_dll.rc ('k') | chrome/browser/chromeos/system/ash_system_tray_delegate.cc » ('j') | chrome/browser/ui/views/frame/browser_view.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698