Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Side by Side Diff: chrome/browser/ui/browser.cc

Issue 10546072: Use different help URLs for menus, accelerators, and WebUI. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: merge Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/ui/browser.h ('k') | chrome/browser/ui/gtk/accelerators_gtk.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/browser.h" 5 #include "chrome/browser/ui/browser.h"
6 6
7 #if defined(OS_WIN) 7 #if defined(OS_WIN)
8 #include <windows.h> 8 #include <windows.h>
9 #include <shellapi.h> 9 #include <shellapi.h>
10 #endif // OS_WIN 10 #endif // OS_WIN
(...skipping 672 matching lines...) Expand 10 before | Expand all | Expand 10 after
683 } 683 }
684 684
685 // static 685 // static
686 void Browser::OpenDownloadsWindow(Profile* profile) { 686 void Browser::OpenDownloadsWindow(Profile* profile) {
687 Browser* browser = Browser::Create(profile); 687 Browser* browser = Browser::Create(profile);
688 browser->ShowDownloadsTab(); 688 browser->ShowDownloadsTab();
689 browser->window()->Show(); 689 browser->window()->Show();
690 } 690 }
691 691
692 // static 692 // static
693 void Browser::OpenHelpWindow(Profile* profile) { 693 void Browser::OpenHelpWindow(Profile* profile, HelpSource source) {
694 Browser* browser = Browser::Create(profile); 694 Browser* browser = Browser::Create(profile);
695 browser->ShowHelpTab(); 695 browser->ShowHelpTab(source);
696 browser->window()->Show(); 696 browser->window()->Show();
697 } 697 }
698 698
699 // static 699 // static
700 void Browser::OpenOptionsWindow(Profile* profile) { 700 void Browser::OpenOptionsWindow(Profile* profile) {
701 Browser* browser = Browser::Create(profile); 701 Browser* browser = Browser::Create(profile);
702 browser->OpenOptionsDialog(); 702 browser->OpenOptionsDialog();
703 browser->window()->Show(); 703 browser->window()->Show();
704 } 704 }
705 705
(...skipping 1275 matching lines...) Expand 10 before | Expand all | Expand 10 after
1981 // crbug.com/115123. 1981 // crbug.com/115123.
1982 window_->ShowAboutChromeDialog(); 1982 window_->ShowAboutChromeDialog();
1983 #endif 1983 #endif
1984 } 1984 }
1985 1985
1986 void Browser::OpenUpdateChromeDialog() { 1986 void Browser::OpenUpdateChromeDialog() {
1987 content::RecordAction(UserMetricsAction("UpdateChrome")); 1987 content::RecordAction(UserMetricsAction("UpdateChrome"));
1988 window_->ShowUpdateChromeDialog(); 1988 window_->ShowUpdateChromeDialog();
1989 } 1989 }
1990 1990
1991 void Browser::ShowHelpTab() { 1991 void Browser::ShowHelpTab(HelpSource source) {
1992 content::RecordAction(UserMetricsAction("ShowHelpTab")); 1992 content::RecordAction(UserMetricsAction("ShowHelpTab"));
1993 ShowSingletonTab(GURL(chrome::kChromeHelpURL)); 1993 GURL url;
1994 switch (source) {
1995 case HELP_SOURCE_KEYBOARD:
1996 url = GURL(chrome::kChromeHelpViaKeyboardURL);
1997 break;
1998 case HELP_SOURCE_MENU:
1999 url = GURL(chrome::kChromeHelpViaMenuURL);
2000 break;
2001 case HELP_SOURCE_WEBUI:
2002 url = GURL(chrome::kChromeHelpViaWebUIURL);
2003 break;
2004 default:
2005 NOTREACHED() << "Unhandled help source " << source;
2006 }
2007 ShowSingletonTab(url);
1994 } 2008 }
1995 2009
1996 void Browser::OpenPrivacyDashboardTabAndActivate() { 2010 void Browser::OpenPrivacyDashboardTabAndActivate() {
1997 OpenURL(OpenURLParams( 2011 OpenURL(OpenURLParams(
1998 GURL(kPrivacyDashboardUrl), Referrer(), 2012 GURL(kPrivacyDashboardUrl), Referrer(),
1999 NEW_FOREGROUND_TAB, content::PAGE_TRANSITION_LINK, false)); 2013 NEW_FOREGROUND_TAB, content::PAGE_TRANSITION_LINK, false));
2000 window_->Activate(); 2014 window_->Activate();
2001 } 2015 }
2002 2016
2003 void Browser::OpenSearchEngineOptionsDialog() { 2017 void Browser::OpenSearchEngineOptionsDialog() {
(...skipping 476 matching lines...) Expand 10 before | Expand all | Expand 10 after
2480 case IDC_SELECT_TAB_4: 2494 case IDC_SELECT_TAB_4:
2481 case IDC_SELECT_TAB_5: 2495 case IDC_SELECT_TAB_5:
2482 case IDC_SELECT_TAB_6: 2496 case IDC_SELECT_TAB_6:
2483 case IDC_SELECT_TAB_7: SelectNumberedTab(id - IDC_SELECT_TAB_0); 2497 case IDC_SELECT_TAB_7: SelectNumberedTab(id - IDC_SELECT_TAB_0);
2484 break; 2498 break;
2485 case IDC_SELECT_LAST_TAB: SelectLastTab(); break; 2499 case IDC_SELECT_LAST_TAB: SelectLastTab(); break;
2486 case IDC_DUPLICATE_TAB: DuplicateTab(); break; 2500 case IDC_DUPLICATE_TAB: DuplicateTab(); break;
2487 case IDC_RESTORE_TAB: RestoreTab(); break; 2501 case IDC_RESTORE_TAB: RestoreTab(); break;
2488 case IDC_COPY_URL: WriteCurrentURLToClipboard(); break; 2502 case IDC_COPY_URL: WriteCurrentURLToClipboard(); break;
2489 case IDC_SHOW_AS_TAB: ConvertPopupToTabbedBrowser(); break; 2503 case IDC_SHOW_AS_TAB: ConvertPopupToTabbedBrowser(); break;
2490 case IDC_FULLSCREEN: ToggleFullscreenMode(); break; 2504 case IDC_FULLSCREEN: ToggleFullscreenMode(); break;
2491 #if defined(OS_MACOSX) 2505 #if defined(OS_MACOSX)
2492 case IDC_PRESENTATION_MODE: TogglePresentationMode(); break; 2506 case IDC_PRESENTATION_MODE: TogglePresentationMode(); break;
2493 #endif 2507 #endif
2494 case IDC_EXIT: Exit(); break; 2508 case IDC_EXIT: Exit(); break;
2495 2509
2496 // Page-related commands 2510 // Page-related commands
2497 case IDC_SAVE_PAGE: SavePage(); break; 2511 case IDC_SAVE_PAGE: SavePage(); break;
2498 case IDC_BOOKMARK_PAGE: BookmarkCurrentPage(); break; 2512 case IDC_BOOKMARK_PAGE: BookmarkCurrentPage(); break;
2499 case IDC_PIN_TO_START_SCREEN: PinCurrentPageToStartScreen(); break; 2513 case IDC_PIN_TO_START_SCREEN: PinCurrentPageToStartScreen(); break;
2500 case IDC_BOOKMARK_ALL_TABS: BookmarkAllTabs(); break; 2514 case IDC_BOOKMARK_ALL_TABS: BookmarkAllTabs(); break;
2501 case IDC_VIEW_SOURCE: ViewSelectedSource(); break; 2515 case IDC_VIEW_SOURCE: ViewSelectedSource(); break;
2502 case IDC_EMAIL_PAGE_LOCATION: EmailPageLocation(); break; 2516 case IDC_EMAIL_PAGE_LOCATION: EmailPageLocation(); break;
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
2573 DEVTOOLS_TOGGLE_ACTION_NONE); 2587 DEVTOOLS_TOGGLE_ACTION_NONE);
2574 break; 2588 break;
2575 case IDC_DEV_TOOLS_CONSOLE: ToggleDevToolsWindow( 2589 case IDC_DEV_TOOLS_CONSOLE: ToggleDevToolsWindow(
2576 DEVTOOLS_TOGGLE_ACTION_SHOW_CONSOLE); 2590 DEVTOOLS_TOGGLE_ACTION_SHOW_CONSOLE);
2577 break; 2591 break;
2578 case IDC_DEV_TOOLS_INSPECT: ToggleDevToolsWindow( 2592 case IDC_DEV_TOOLS_INSPECT: ToggleDevToolsWindow(
2579 DEVTOOLS_TOGGLE_ACTION_INSPECT); 2593 DEVTOOLS_TOGGLE_ACTION_INSPECT);
2580 break; 2594 break;
2581 case IDC_TASK_MANAGER: OpenTaskManager(false); break; 2595 case IDC_TASK_MANAGER: OpenTaskManager(false); break;
2582 case IDC_VIEW_BACKGROUND_PAGES: OpenTaskManager(true); break; 2596 case IDC_VIEW_BACKGROUND_PAGES: OpenTaskManager(true); break;
2583 case IDC_FEEDBACK: OpenFeedbackDialog(); break; 2597 case IDC_FEEDBACK: OpenFeedbackDialog(); break;
2584 2598
2585 case IDC_SHOW_BOOKMARK_BAR: ToggleBookmarkBar(); break; 2599 case IDC_SHOW_BOOKMARK_BAR: ToggleBookmarkBar(); break;
2586 case IDC_PROFILING_ENABLED: Profiling::Toggle(); break; 2600 case IDC_PROFILING_ENABLED: Profiling::Toggle(); break;
2587 2601
2588 case IDC_SHOW_BOOKMARK_MANAGER: OpenBookmarkManager(); break; 2602 case IDC_SHOW_BOOKMARK_MANAGER: OpenBookmarkManager(); break;
2589 case IDC_SHOW_APP_MENU: ShowAppMenu(); break; 2603 case IDC_SHOW_APP_MENU: ShowAppMenu(); break;
2590 case IDC_SHOW_AVATAR_MENU: ShowAvatarMenu(); break; 2604 case IDC_SHOW_AVATAR_MENU: ShowAvatarMenu(); break;
2591 case IDC_SHOW_HISTORY: ShowHistoryTab(); break; 2605 case IDC_SHOW_HISTORY: ShowHistoryTab(); break;
2592 case IDC_SHOW_DOWNLOADS: ShowDownloadsTab(); break; 2606 case IDC_SHOW_DOWNLOADS: ShowDownloadsTab(); break;
2593 case IDC_MANAGE_EXTENSIONS: ShowExtensionsTab(); break; 2607 case IDC_MANAGE_EXTENSIONS: ShowExtensionsTab(); break;
2594 case IDC_OPTIONS: OpenOptionsDialog(); break; 2608 case IDC_OPTIONS: OpenOptionsDialog(); break;
2595 case IDC_EDIT_SEARCH_ENGINES: OpenSearchEngineOptionsDialog(); break; 2609 case IDC_EDIT_SEARCH_ENGINES: OpenSearchEngineOptionsDialog(); break;
2596 case IDC_VIEW_PASSWORDS: OpenPasswordManager(); break; 2610 case IDC_VIEW_PASSWORDS: OpenPasswordManager(); break;
2597 case IDC_CLEAR_BROWSING_DATA: OpenClearBrowsingDataDialog(); break; 2611 case IDC_CLEAR_BROWSING_DATA: OpenClearBrowsingDataDialog(); break;
2598 case IDC_IMPORT_SETTINGS: OpenImportSettingsDialog(); break; 2612 case IDC_IMPORT_SETTINGS: OpenImportSettingsDialog(); break;
2599 case IDC_ABOUT: OpenAboutChromeDialog(); break; 2613 case IDC_ABOUT: OpenAboutChromeDialog(); break;
2600 case IDC_UPGRADE_DIALOG: OpenUpdateChromeDialog(); break; 2614 case IDC_UPGRADE_DIALOG: OpenUpdateChromeDialog(); break;
2601 case IDC_VIEW_INCOMPATIBILITIES: ShowAboutConflictsTab(); break; 2615 case IDC_VIEW_INCOMPATIBILITIES: ShowAboutConflictsTab(); break;
2602 case IDC_HELP_PAGE: ShowHelpTab(); break; 2616 case IDC_HELP_PAGE_VIA_KEYBOARD: ShowHelpTab(HELP_SOURCE_KEYBOARD); break;
2617 case IDC_HELP_PAGE_VIA_MENU: ShowHelpTab(HELP_SOURCE_MENU); break;
2603 case IDC_SHOW_SYNC_SETUP: ShowSyncSetup(SyncPromoUI::SOURCE_MENU); 2618 case IDC_SHOW_SYNC_SETUP: ShowSyncSetup(SyncPromoUI::SOURCE_MENU);
2604 break; 2619 break;
2605 case IDC_TOGGLE_SPEECH_INPUT: ToggleSpeechInput(); break; 2620 case IDC_TOGGLE_SPEECH_INPUT: ToggleSpeechInput(); break;
2606 2621
2607 default: 2622 default:
2608 LOG(WARNING) << "Received Unimplemented Command: " << id; 2623 LOG(WARNING) << "Received Unimplemented Command: " << id;
2609 break; 2624 break;
2610 } 2625 }
2611 } 2626 }
2612 2627
(...skipping 1494 matching lines...) Expand 10 before | Expand all | Expand 10 after
4107 command_updater_.UpdateCommandEnabled(IDC_ZOOM_NORMAL, true); 4122 command_updater_.UpdateCommandEnabled(IDC_ZOOM_NORMAL, true);
4108 command_updater_.UpdateCommandEnabled(IDC_ZOOM_MINUS, true); 4123 command_updater_.UpdateCommandEnabled(IDC_ZOOM_MINUS, true);
4109 4124
4110 // Show various bits of UI 4125 // Show various bits of UI
4111 UpdateOpenFileState(); 4126 UpdateOpenFileState();
4112 command_updater_.UpdateCommandEnabled(IDC_CREATE_SHORTCUTS, false); 4127 command_updater_.UpdateCommandEnabled(IDC_CREATE_SHORTCUTS, false);
4113 UpdateCommandsForDevTools(); 4128 UpdateCommandsForDevTools();
4114 command_updater_.UpdateCommandEnabled(IDC_TASK_MANAGER, true); 4129 command_updater_.UpdateCommandEnabled(IDC_TASK_MANAGER, true);
4115 command_updater_.UpdateCommandEnabled(IDC_SHOW_HISTORY, true); 4130 command_updater_.UpdateCommandEnabled(IDC_SHOW_HISTORY, true);
4116 command_updater_.UpdateCommandEnabled(IDC_SHOW_DOWNLOADS, true); 4131 command_updater_.UpdateCommandEnabled(IDC_SHOW_DOWNLOADS, true);
4117 command_updater_.UpdateCommandEnabled(IDC_HELP_PAGE, true); 4132 command_updater_.UpdateCommandEnabled(IDC_HELP_PAGE_VIA_KEYBOARD, true);
4133 command_updater_.UpdateCommandEnabled(IDC_HELP_PAGE_VIA_MENU, true);
4118 command_updater_.UpdateCommandEnabled(IDC_BOOKMARKS_MENU, true); 4134 command_updater_.UpdateCommandEnabled(IDC_BOOKMARKS_MENU, true);
4119 4135
4120 command_updater_.UpdateCommandEnabled( 4136 command_updater_.UpdateCommandEnabled(
4121 IDC_SHOW_SYNC_SETUP, profile_->GetOriginalProfile()->IsSyncAccessible()); 4137 IDC_SHOW_SYNC_SETUP, profile_->GetOriginalProfile()->IsSyncAccessible());
4122 4138
4123 // Initialize other commands based on the window type. 4139 // Initialize other commands based on the window type.
4124 bool normal_window = is_type_tabbed(); 4140 bool normal_window = is_type_tabbed();
4125 4141
4126 // Navigation commands 4142 // Navigation commands
4127 command_updater_.UpdateCommandEnabled(IDC_HOME, normal_window); 4143 command_updater_.UpdateCommandEnabled(IDC_HOME, normal_window);
(...skipping 1044 matching lines...) Expand 10 before | Expand all | Expand 10 after
5172 if (contents && !allow_js_access) { 5188 if (contents && !allow_js_access) {
5173 contents->web_contents()->GetController().LoadURL( 5189 contents->web_contents()->GetController().LoadURL(
5174 target_url, 5190 target_url,
5175 content::Referrer(), 5191 content::Referrer(),
5176 content::PAGE_TRANSITION_LINK, 5192 content::PAGE_TRANSITION_LINK,
5177 std::string()); // No extra headers. 5193 std::string()); // No extra headers.
5178 } 5194 }
5179 5195
5180 return contents != NULL; 5196 return contents != NULL;
5181 } 5197 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/browser.h ('k') | chrome/browser/ui/gtk/accelerators_gtk.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698