Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(964)

Side by Side Diff: chrome/browser/ui/browser.cc

Issue 10546072: Use different help URLs for menus, accelerators, and WebUI. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix mac compile Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/browser.h" 5 #include "chrome/browser/ui/browser.h"
6 6
7 #if defined(OS_WIN) 7 #if defined(OS_WIN)
8 #include <windows.h> 8 #include <windows.h>
9 #include <shellapi.h> 9 #include <shellapi.h>
10 #endif // OS_WIN 10 #endif // OS_WIN
(...skipping 673 matching lines...) Expand 10 before | Expand all | Expand 10 after
684 } 684 }
685 685
686 // static 686 // static
687 void Browser::OpenDownloadsWindow(Profile* profile) { 687 void Browser::OpenDownloadsWindow(Profile* profile) {
688 Browser* browser = Browser::Create(profile); 688 Browser* browser = Browser::Create(profile);
689 browser->ShowDownloadsTab(); 689 browser->ShowDownloadsTab();
690 browser->window()->Show(); 690 browser->window()->Show();
691 } 691 }
692 692
693 // static 693 // static
694 void Browser::OpenHelpWindow(Profile* profile) { 694 void Browser::OpenHelpWindow(Profile* profile, HelpSource source) {
695 Browser* browser = Browser::Create(profile); 695 Browser* browser = Browser::Create(profile);
696 browser->ShowHelpTab(); 696 browser->ShowHelpTab(source);
697 browser->window()->Show(); 697 browser->window()->Show();
698 } 698 }
699 699
700 // static 700 // static
701 void Browser::OpenOptionsWindow(Profile* profile) { 701 void Browser::OpenOptionsWindow(Profile* profile) {
702 Browser* browser = Browser::Create(profile); 702 Browser* browser = Browser::Create(profile);
703 browser->OpenOptionsDialog(); 703 browser->OpenOptionsDialog();
704 browser->window()->Show(); 704 browser->window()->Show();
705 } 705 }
706 706
(...skipping 1275 matching lines...) Expand 10 before | Expand all | Expand 10 after
1982 // crbug.com/115123. 1982 // crbug.com/115123.
1983 window_->ShowAboutChromeDialog(); 1983 window_->ShowAboutChromeDialog();
1984 #endif 1984 #endif
1985 } 1985 }
1986 1986
1987 void Browser::OpenUpdateChromeDialog() { 1987 void Browser::OpenUpdateChromeDialog() {
1988 content::RecordAction(UserMetricsAction("UpdateChrome")); 1988 content::RecordAction(UserMetricsAction("UpdateChrome"));
1989 window_->ShowUpdateChromeDialog(); 1989 window_->ShowUpdateChromeDialog();
1990 } 1990 }
1991 1991
1992 void Browser::ShowHelpTab() { 1992 void Browser::ShowHelpTab(HelpSource source) {
1993 content::RecordAction(UserMetricsAction("ShowHelpTab")); 1993 content::RecordAction(UserMetricsAction("ShowHelpTab"));
1994 ShowSingletonTab(GURL(chrome::kChromeHelpURL)); 1994 GURL url;
1995 switch (source) {
1996 case HELP_SOURCE_KEYBOARD:
1997 url = GURL(chrome::kChromeHelpViaKeyboardURL);
1998 break;
1999 case HELP_SOURCE_MENU:
2000 url = GURL(chrome::kChromeHelpViaMenuURL);
2001 break;
2002 case HELP_SOURCE_WEBUI:
2003 url = GURL(chrome::kChromeHelpViaWebUIURL);
2004 break;
2005 default:
2006 NOTREACHED() << "Unhandled help source " << source;
2007 }
2008 ShowSingletonTab(url);
1995 } 2009 }
1996 2010
1997 void Browser::OpenPrivacyDashboardTabAndActivate() { 2011 void Browser::OpenPrivacyDashboardTabAndActivate() {
1998 OpenURL(OpenURLParams( 2012 OpenURL(OpenURLParams(
1999 GURL(kPrivacyDashboardUrl), Referrer(), 2013 GURL(kPrivacyDashboardUrl), Referrer(),
2000 NEW_FOREGROUND_TAB, content::PAGE_TRANSITION_LINK, false)); 2014 NEW_FOREGROUND_TAB, content::PAGE_TRANSITION_LINK, false));
2001 window_->Activate(); 2015 window_->Activate();
2002 } 2016 }
2003 2017
2004 void Browser::OpenSearchEngineOptionsDialog() { 2018 void Browser::OpenSearchEngineOptionsDialog() {
(...skipping 476 matching lines...) Expand 10 before | Expand all | Expand 10 after
2481 case IDC_SELECT_TAB_4: 2495 case IDC_SELECT_TAB_4:
2482 case IDC_SELECT_TAB_5: 2496 case IDC_SELECT_TAB_5:
2483 case IDC_SELECT_TAB_6: 2497 case IDC_SELECT_TAB_6:
2484 case IDC_SELECT_TAB_7: SelectNumberedTab(id - IDC_SELECT_TAB_0); 2498 case IDC_SELECT_TAB_7: SelectNumberedTab(id - IDC_SELECT_TAB_0);
2485 break; 2499 break;
2486 case IDC_SELECT_LAST_TAB: SelectLastTab(); break; 2500 case IDC_SELECT_LAST_TAB: SelectLastTab(); break;
2487 case IDC_DUPLICATE_TAB: DuplicateTab(); break; 2501 case IDC_DUPLICATE_TAB: DuplicateTab(); break;
2488 case IDC_RESTORE_TAB: RestoreTab(); break; 2502 case IDC_RESTORE_TAB: RestoreTab(); break;
2489 case IDC_COPY_URL: WriteCurrentURLToClipboard(); break; 2503 case IDC_COPY_URL: WriteCurrentURLToClipboard(); break;
2490 case IDC_SHOW_AS_TAB: ConvertPopupToTabbedBrowser(); break; 2504 case IDC_SHOW_AS_TAB: ConvertPopupToTabbedBrowser(); break;
2491 case IDC_FULLSCREEN: ToggleFullscreenMode(); break; 2505 case IDC_FULLSCREEN: ToggleFullscreenMode(); break;
2492 #if defined(OS_MACOSX) 2506 #if defined(OS_MACOSX)
2493 case IDC_PRESENTATION_MODE: TogglePresentationMode(); break; 2507 case IDC_PRESENTATION_MODE: TogglePresentationMode(); break;
2494 #endif 2508 #endif
2495 case IDC_EXIT: Exit(); break; 2509 case IDC_EXIT: Exit(); break;
2496 2510
2497 // Page-related commands 2511 // Page-related commands
2498 case IDC_SAVE_PAGE: SavePage(); break; 2512 case IDC_SAVE_PAGE: SavePage(); break;
2499 case IDC_BOOKMARK_PAGE: BookmarkCurrentPage(); break; 2513 case IDC_BOOKMARK_PAGE: BookmarkCurrentPage(); break;
2500 case IDC_PIN_TO_START_SCREEN: PinCurrentPageToStartScreen(); break; 2514 case IDC_PIN_TO_START_SCREEN: PinCurrentPageToStartScreen(); break;
2501 case IDC_BOOKMARK_ALL_TABS: BookmarkAllTabs(); break; 2515 case IDC_BOOKMARK_ALL_TABS: BookmarkAllTabs(); break;
2502 case IDC_VIEW_SOURCE: ViewSelectedSource(); break; 2516 case IDC_VIEW_SOURCE: ViewSelectedSource(); break;
2503 case IDC_EMAIL_PAGE_LOCATION: EmailPageLocation(); break; 2517 case IDC_EMAIL_PAGE_LOCATION: EmailPageLocation(); break;
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
2574 DEVTOOLS_TOGGLE_ACTION_NONE); 2588 DEVTOOLS_TOGGLE_ACTION_NONE);
2575 break; 2589 break;
2576 case IDC_DEV_TOOLS_CONSOLE: ToggleDevToolsWindow( 2590 case IDC_DEV_TOOLS_CONSOLE: ToggleDevToolsWindow(
2577 DEVTOOLS_TOGGLE_ACTION_SHOW_CONSOLE); 2591 DEVTOOLS_TOGGLE_ACTION_SHOW_CONSOLE);
2578 break; 2592 break;
2579 case IDC_DEV_TOOLS_INSPECT: ToggleDevToolsWindow( 2593 case IDC_DEV_TOOLS_INSPECT: ToggleDevToolsWindow(
2580 DEVTOOLS_TOGGLE_ACTION_INSPECT); 2594 DEVTOOLS_TOGGLE_ACTION_INSPECT);
2581 break; 2595 break;
2582 case IDC_TASK_MANAGER: OpenTaskManager(false); break; 2596 case IDC_TASK_MANAGER: OpenTaskManager(false); break;
2583 case IDC_VIEW_BACKGROUND_PAGES: OpenTaskManager(true); break; 2597 case IDC_VIEW_BACKGROUND_PAGES: OpenTaskManager(true); break;
2584 case IDC_FEEDBACK: OpenFeedbackDialog(); break; 2598 case IDC_FEEDBACK: OpenFeedbackDialog(); break;
2585 2599
2586 case IDC_SHOW_BOOKMARK_BAR: ToggleBookmarkBar(); break; 2600 case IDC_SHOW_BOOKMARK_BAR: ToggleBookmarkBar(); break;
2587 case IDC_PROFILING_ENABLED: Profiling::Toggle(); break; 2601 case IDC_PROFILING_ENABLED: Profiling::Toggle(); break;
2588 2602
2589 case IDC_SHOW_BOOKMARK_MANAGER: OpenBookmarkManager(); break; 2603 case IDC_SHOW_BOOKMARK_MANAGER: OpenBookmarkManager(); break;
2590 case IDC_SHOW_APP_MENU: ShowAppMenu(); break; 2604 case IDC_SHOW_APP_MENU: ShowAppMenu(); break;
2591 case IDC_SHOW_AVATAR_MENU: ShowAvatarMenu(); break; 2605 case IDC_SHOW_AVATAR_MENU: ShowAvatarMenu(); break;
2592 case IDC_SHOW_HISTORY: ShowHistoryTab(); break; 2606 case IDC_SHOW_HISTORY: ShowHistoryTab(); break;
2593 case IDC_SHOW_DOWNLOADS: ShowDownloadsTab(); break; 2607 case IDC_SHOW_DOWNLOADS: ShowDownloadsTab(); break;
2594 case IDC_MANAGE_EXTENSIONS: ShowExtensionsTab(); break; 2608 case IDC_MANAGE_EXTENSIONS: ShowExtensionsTab(); break;
2595 case IDC_OPTIONS: OpenOptionsDialog(); break; 2609 case IDC_OPTIONS: OpenOptionsDialog(); break;
2596 case IDC_EDIT_SEARCH_ENGINES: OpenSearchEngineOptionsDialog(); break; 2610 case IDC_EDIT_SEARCH_ENGINES: OpenSearchEngineOptionsDialog(); break;
2597 case IDC_VIEW_PASSWORDS: OpenPasswordManager(); break; 2611 case IDC_VIEW_PASSWORDS: OpenPasswordManager(); break;
2598 case IDC_CLEAR_BROWSING_DATA: OpenClearBrowsingDataDialog(); break; 2612 case IDC_CLEAR_BROWSING_DATA: OpenClearBrowsingDataDialog(); break;
2599 case IDC_IMPORT_SETTINGS: OpenImportSettingsDialog(); break; 2613 case IDC_IMPORT_SETTINGS: OpenImportSettingsDialog(); break;
2600 case IDC_ABOUT: OpenAboutChromeDialog(); break; 2614 case IDC_ABOUT: OpenAboutChromeDialog(); break;
2601 case IDC_UPGRADE_DIALOG: OpenUpdateChromeDialog(); break; 2615 case IDC_UPGRADE_DIALOG: OpenUpdateChromeDialog(); break;
2602 case IDC_VIEW_INCOMPATIBILITIES: ShowAboutConflictsTab(); break; 2616 case IDC_VIEW_INCOMPATIBILITIES: ShowAboutConflictsTab(); break;
2603 case IDC_HELP_PAGE: ShowHelpTab(); break; 2617 case IDC_HELP_PAGE_VIA_KEYBOARD: ShowHelpTab(HELP_SOURCE_KEYBOARD); break;
2618 case IDC_HELP_PAGE_VIA_MENU: ShowHelpTab(HELP_SOURCE_MENU); break;
2604 case IDC_SHOW_SYNC_SETUP: ShowSyncSetup(SyncPromoUI::SOURCE_MENU); 2619 case IDC_SHOW_SYNC_SETUP: ShowSyncSetup(SyncPromoUI::SOURCE_MENU);
2605 break; 2620 break;
2606 case IDC_TOGGLE_SPEECH_INPUT: ToggleSpeechInput(); break; 2621 case IDC_TOGGLE_SPEECH_INPUT: ToggleSpeechInput(); break;
2607 2622
2608 default: 2623 default:
2609 LOG(WARNING) << "Received Unimplemented Command: " << id; 2624 LOG(WARNING) << "Received Unimplemented Command: " << id;
2610 break; 2625 break;
2611 } 2626 }
2612 } 2627 }
2613 2628
(...skipping 1494 matching lines...) Expand 10 before | Expand all | Expand 10 after
4108 command_updater_.UpdateCommandEnabled(IDC_ZOOM_NORMAL, true); 4123 command_updater_.UpdateCommandEnabled(IDC_ZOOM_NORMAL, true);
4109 command_updater_.UpdateCommandEnabled(IDC_ZOOM_MINUS, true); 4124 command_updater_.UpdateCommandEnabled(IDC_ZOOM_MINUS, true);
4110 4125
4111 // Show various bits of UI 4126 // Show various bits of UI
4112 UpdateOpenFileState(); 4127 UpdateOpenFileState();
4113 command_updater_.UpdateCommandEnabled(IDC_CREATE_SHORTCUTS, false); 4128 command_updater_.UpdateCommandEnabled(IDC_CREATE_SHORTCUTS, false);
4114 UpdateCommandsForDevTools(); 4129 UpdateCommandsForDevTools();
4115 command_updater_.UpdateCommandEnabled(IDC_TASK_MANAGER, true); 4130 command_updater_.UpdateCommandEnabled(IDC_TASK_MANAGER, true);
4116 command_updater_.UpdateCommandEnabled(IDC_SHOW_HISTORY, true); 4131 command_updater_.UpdateCommandEnabled(IDC_SHOW_HISTORY, true);
4117 command_updater_.UpdateCommandEnabled(IDC_SHOW_DOWNLOADS, true); 4132 command_updater_.UpdateCommandEnabled(IDC_SHOW_DOWNLOADS, true);
4118 command_updater_.UpdateCommandEnabled(IDC_HELP_PAGE, true); 4133 command_updater_.UpdateCommandEnabled(IDC_HELP_PAGE_VIA_KEYBOARD, true);
4134 command_updater_.UpdateCommandEnabled(IDC_HELP_PAGE_VIA_MENU, true);
4119 command_updater_.UpdateCommandEnabled(IDC_BOOKMARKS_MENU, true); 4135 command_updater_.UpdateCommandEnabled(IDC_BOOKMARKS_MENU, true);
4120 4136
4121 command_updater_.UpdateCommandEnabled( 4137 command_updater_.UpdateCommandEnabled(
4122 IDC_SHOW_SYNC_SETUP, profile_->GetOriginalProfile()->IsSyncAccessible()); 4138 IDC_SHOW_SYNC_SETUP, profile_->GetOriginalProfile()->IsSyncAccessible());
4123 4139
4124 // Initialize other commands based on the window type. 4140 // Initialize other commands based on the window type.
4125 bool normal_window = is_type_tabbed(); 4141 bool normal_window = is_type_tabbed();
4126 4142
4127 // Navigation commands 4143 // Navigation commands
4128 command_updater_.UpdateCommandEnabled(IDC_HOME, normal_window); 4144 command_updater_.UpdateCommandEnabled(IDC_HOME, normal_window);
(...skipping 1044 matching lines...) Expand 10 before | Expand all | Expand 10 after
5173 if (contents && !allow_js_access) { 5189 if (contents && !allow_js_access) {
5174 contents->web_contents()->GetController().LoadURL( 5190 contents->web_contents()->GetController().LoadURL(
5175 target_url, 5191 target_url,
5176 content::Referrer(), 5192 content::Referrer(),
5177 content::PAGE_TRANSITION_LINK, 5193 content::PAGE_TRANSITION_LINK,
5178 std::string()); // No extra headers. 5194 std::string()); // No extra headers.
5179 } 5195 }
5180 5196
5181 return contents != NULL; 5197 return contents != NULL;
5182 } 5198 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698